Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Redux types #58

Open
tskarhed opened this issue Sep 25, 2020 · 3 comments
Open

Organize Redux types #58

tskarhed opened this issue Sep 25, 2020 · 3 comments

Comments

@tskarhed
Copy link
Owner

The types are all in one file, I think it's mostly related to Redux. Some reorganization is needed, as it is getting quite complex. Any input is helpful!

https://github.com/tskarhed/setlist/blob/master/src/state/types.ts

@PranjalAgni
Copy link

I think if we break the reducers and action creators in their own files then it would be more manageable in long term. We can also group the redux action types with its specific action creator

@tskarhed
Copy link
Owner Author

Sounds like a good idea! I am considering removing the specific actions, in favor of more general ones, such as UPDATE_SONG. This is to easier sync with Firebase (#61)

@PranjalAgni
Copy link

Yes looking at number of action/reducers app has currently, we need to first group the similar types of actions in their separate files and also take care while refactoring we do not miss something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants