Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll bar included in transistion #22

Open
danielbwa opened this issue May 9, 2012 · 3 comments
Open

scroll bar included in transistion #22

danielbwa opened this issue May 9, 2012 · 3 comments

Comments

@danielbwa
Copy link

Hey Andrew,

First of all: thank you for app UI.

In my project i have some pretty long pages so iScroll comes in and adds the scroll bar to the container... Now when i load new content in the container by using window.splitViewNavigator.replaceBodyView( content ); the transition includes the scroll bar from iScroll. Only on Chrome and Safari desktop.. on mobile the bar disappears nicely after scrolling.

Would be nice to have the bar excluded from the transistion, any ideas?

Thanks, Daniel

@triceam
Copy link
Owner

triceam commented May 9, 2012

You're welcome for app-UI! Thanks for giving it a try. For a quick fix, try going into ViewNavigator.js and add the following code at the beginning of the updateView method:

if ( this.scroller != null && this.scroller != undefined ) {
this.scroller.destroy();
this.scroller = null;
}

I think that will fix it for you, but I haven't tested it yet. I'd love to see what you are building once its complete!

@danielbwa
Copy link
Author

Yep, that does the job :)

tanks for the fast reply, i think this is something nice to add in the new version?

for now App-UI is really what i was looking for, splitview and nice transistions and it preforms good until now. Of course i have some questions about it but thats maybe out of the scope of this issue ;)

@triceam triceam reopened this May 10, 2012
@triceam
Copy link
Owner

triceam commented May 10, 2012

reopening, so i remember to add it back into the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants