cc: Remove obsolete abi pipeline interface.

Author: xlauko

include/vast/Target/LLVMIR/Convert.hpp

@@ -25,19 +25,6 @@ namespace mlir
 
 namespace vast::target::llvmir
 {
-    // TODO(target): Do we want to fully replace this with composite passes,
-    //               or instead should live at the same time?
-    enum class pipeline : uint32_t
-    {
-        baseline = 0,
-        with_abi = 1
-    };
-
-    static inline pipeline default_pipeline()
-    {
-        return pipeline::baseline;
-    }
-
     // Lower module into `llvm::Module` - it is expected that `mlir_module` is already
     // lowered as much as possible by vast (for example by calling the `prepare_module`
     // function).

lib/vast/Frontend/Consumer.cpp

@@ -26,14 +26,6 @@ VAST_UNRELAX_WARNINGS
 
 namespace vast::cc {
 
-    namespace llvmir = target::llvmir;
-
-    using pipeline = llvmir::pipeline;
-
-    [[nodiscard]] pipeline parse_pipeline(const std::optional< vast_args::option_list > &list);
-
-    [[nodiscard]] pipeline parse_pipeline(string_ref from);
-
     [[nodiscard]] target_dialect parse_target_dialect(string_ref from);
 
     [[nodiscard]] std::string to_string(target_dialect target);
@@ -177,11 +169,8 @@ namespace vast::cc {
         backend backend_action, owning_module_ref mlir_module, mcontext_t *mctx
     ) {
         llvm::LLVMContext llvm_context;
-        llvmir::register_vast_to_llvm_ir(*mctx);
-        // auto pipeline = parse_pipeline(vargs.get_options_list(opt::opt_pipeline));
-        // llvmir::lower_hl_module(mlir_module.get(), pipeline);
 
-        auto mod = llvmir::translate(mlir_module.get(), llvm_context);
+        auto mod = target::llvmir::translate(mlir_module.get(), llvm_context);
         auto dl  = cgctx->actx.getTargetInfo().getDataLayoutString();
         clang::EmitBackendOutput(
             opts.diags, opts.headers, opts.codegen, opts.target, opts.lang, dl, mod.get(),
@@ -259,29 +248,4 @@ namespace vast::cc {
         VAST_UNIMPLEMENTED_MSG("VAST does not yet support the given source language");
     }
 
-    pipeline parse_pipeline(const std::optional< vast_args::option_list > &list) {
-        if (!list) {
-            return llvmir::default_pipeline();
-        }
-
-        if (list->size() != 1) {
-            VAST_UNREACHABLE("Cannot use more than one pipeline!");
-        }
-
-        return parse_pipeline(list->front());
-    }
-
-    pipeline parse_pipeline(string_ref from) {
-        auto trg = from.lower();
-        if (trg == "with-abi") {
-            return pipeline::with_abi;
-        }
-        if (trg == "baseline") {
-            return pipeline::baseline;
-        }
-
-        VAST_UNREACHABLE("Unknown option of pipeline to use: {0}", trg);
-    }
-
-
 } // namespace vast::cc

lib/vast/Target/LLVMIR/Convert.cpp

@@ -30,33 +30,6 @@ VAST_UNRELAX_WARNINGS
 
 namespace vast::target::llvmir
 {
-    namespace
-    {
-        // TODO(target): Unify with tower and opt.
-        void populate_pm(mlir::PassManager &pm, pipeline p)
-        {
-            switch (p)
-            {
-                case pipeline::baseline:
-                {
-                    hl::build_simplify_hl_pipeline(pm);
-                    build_to_ll_pipeline(pm);
-                    build_to_llvm_pipeline(pm);
-                    return;
-                }
-                case pipeline::with_abi:
-                {
-                    hl::build_simplify_hl_pipeline(pm);
-                    build_abi_pipeline(pm);
-                    build_to_ll_pipeline(pm);
-                    build_to_llvm_pipeline(pm);
-                    return;
-                }
-            }
-
-        }
-    } // namespace
-
     class ToLLVMIR : public mlir::LLVMTranslationDialectInterface
     {
       public: