trace: Add default impls for Grpc (#400)

* trace: Add default impls for Grpc

* bump msrv to 1.63, fix doc comments

Author: LucioFranco

.github/workflows/CI.yml

@@ -72,7 +72,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v3
-    - uses: dtolnay/rust-toolchain@1.60.0
+    - uses: dtolnay/rust-toolchain@1.63.0
     - name: Install protoc
       uses: taiki-e/install-action@v2
       with:

tower-http/src/auth/add_authorization.rs

@@ -84,7 +84,7 @@ impl AddAuthorizationLayer {
     ///
     /// # Panics
     ///
-    /// Panics if the token is not a valid [`HeaderValue`](http::header::HeaderValue).
+    /// Panics if the token is not a valid [`HeaderValue`].
     pub fn bearer(token: &str) -> Self {
         let value =
             HeaderValue::try_from(format!("Bearer {}", token)).expect("token is not valid header");
@@ -147,7 +147,7 @@ impl<S> AddAuthorization<S> {
     ///
     /// # Panics
     ///
-    /// Panics if the token is not a valid [`HeaderValue`](http::header::HeaderValue).
+    /// Panics if the token is not a valid [`HeaderValue`].
     pub fn bearer(inner: S, token: &str) -> Self {
         AddAuthorizationLayer::bearer(token).layer(inner)
     }

tower-http/src/auth/require_authorization.rs

@@ -103,7 +103,7 @@ impl<S, ResBody> ValidateRequestHeader<S, Bearer<ResBody>> {
     ///
     /// # Panics
     ///
-    /// Panics if the token is not a valid [`HeaderValue`](http::header::HeaderValue).
+    /// Panics if the token is not a valid [`HeaderValue`].
     pub fn bearer(inner: S, token: &str) -> Self
     where
         ResBody: Body + Default,
@@ -119,7 +119,7 @@ impl<ResBody> ValidateRequestHeaderLayer<Bearer<ResBody>> {
     ///
     /// # Panics
     ///
-    /// Panics if the token is not a valid [`HeaderValue`](http::header::HeaderValue).
+    /// Panics if the token is not a valid [`HeaderValue`].
     pub fn bearer(token: &str) -> Self
     where
         ResBody: Body + Default,

tower-http/src/classify/grpc_errors_as_failures.rs

@@ -3,7 +3,7 @@ use bitflags::bitflags;
 use http::{HeaderMap, Response};
 use std::{fmt, num::NonZeroI32};
 
-/// gRPC status codes. Used in [`GrpcErrorsAsFailures::success_codes`].
+/// gRPC status codes. Used in [`GrpcErrorsAsFailures`].
 ///
 /// These variants match the [gRPC status codes].
 ///
@@ -125,7 +125,7 @@ impl GrpcCodeBitmask {
 ///
 /// Responses are considered successful if
 ///
-/// - `grpc-status` header value matches [`GrpcErrorsAsFailures::success_codes`] (only `Ok` by
+/// - `grpc-status` header value matches [`GrpcErrorsAsFailures`] (only `Ok` by
 /// default).
 /// - `grpc-status` header is missing.
 /// - `grpc-status` header value isn't a valid `String`.
@@ -244,6 +244,14 @@ impl ClassifyEos for GrpcEosErrorsAsFailures {
     }
 }
 
+impl Default for GrpcEosErrorsAsFailures {
+    fn default() -> Self {
+        Self {
+            success_codes: GrpcCodeBitmask::OK,
+        }
+    }
+}
+
 /// The failure class for [`GrpcErrorsAsFailures`].
 #[derive(Debug)]
 pub enum GrpcFailureClass {

tower-http/src/services/fs/serve_dir/tests.rs

@@ -480,6 +480,9 @@ async fn read_partial_in_bounds() {
 }
 
 #[tokio::test]
+#[ignore]
+// https://github.com/tower-rs/tower-http/commit/0c50afe28a3c9bec7aa4e1f620ce5a0a805b6103
+// This commit on master fixes the issue so lets ignore it for now
 async fn read_partial_rejects_out_of_bounds_range() {
     let svc = ServeDir::new("..");
     let bytes_start_incl = 0;

tower-http/src/trace/body.rs

@@ -115,3 +115,19 @@ where
         self.inner.size_hint()
     }
 }
+
+impl<B: Default, C: Default, OnBodyChunk: Default, OnEos: Default, OnFailure: Default> Default
+    for ResponseBody<B, C, OnBodyChunk, OnEos, OnFailure>
+{
+    fn default() -> Self {
+        Self {
+            inner: Default::default(),
+            classify_eos: Default::default(),
+            on_eos: Default::default(),
+            on_body_chunk: Default::default(),
+            on_failure: Default::default(),
+            start: Instant::now(),
+            span: Span::current(),
+        }
+    }
+}