From baf46e8e78db0bc29089b37f4cacebcfa7179004 Mon Sep 17 00:00:00 2001 From: Jonghyeon Ko Date: Wed, 14 Aug 2024 14:13:18 +0900 Subject: [PATCH] ci(vitest): update eslint rule --- configs/eslint-config-js/no-import.js | 7 +++++- packages/cache/src/cacheOptions.test-d.tsx | 4 +--- .../src/SuspenseInfiniteQuery.test-d.tsx | 5 +--- .../src/SuspenseQuery.test-d.tsx | 5 +--- .../src/useSuspenseInfiniteQuery.test-d.ts | 4 +--- .../src/useSuspenseQueries.test-d.ts | 4 +--- .../src/useSuspenseQuery.test-d.ts | 4 +--- .../src/SuspenseInfiniteQuery.test-d.tsx | 5 +--- .../src/SuspenseQuery.test-d.tsx | 5 +--- packages/utils/src/OmitKeyof.test-d.ts | 24 +++++++++---------- 10 files changed, 26 insertions(+), 41 deletions(-) diff --git a/configs/eslint-config-js/no-import.js b/configs/eslint-config-js/no-import.js index 5b3f80c88..de4a7dece 100644 --- a/configs/eslint-config-js/no-import.js +++ b/configs/eslint-config-js/no-import.js @@ -34,9 +34,14 @@ module.exports = { }, overrides: [ { - files: ['*.spec.ts*', '*.test.ts*'], + files: ['*.spec.ts*', '*.test.ts*', '*.test-d.ts*'], plugins: ['@vitest', 'jest-dom'], extends: ['plugin:@vitest/legacy-recommended'], + settings: { + vitest: { + typecheck: true, + }, + }, }, ], } diff --git a/packages/cache/src/cacheOptions.test-d.tsx b/packages/cache/src/cacheOptions.test-d.tsx index 9c47df138..2f0b31576 100644 --- a/packages/cache/src/cacheOptions.test-d.tsx +++ b/packages/cache/src/cacheOptions.test-d.tsx @@ -33,8 +33,6 @@ describe('cacheOptions', () => { }) it('should add DataTag on cacheKey with ReturnType', () => { - expect(() => { - expectTypeOf(cache().cacheKey[dataTagSymbol]).toEqualTypeOf() - }) + expectTypeOf(cache().cacheKey[dataTagSymbol]).toEqualTypeOf() }) }) diff --git a/packages/react-query-4/src/SuspenseInfiniteQuery.test-d.tsx b/packages/react-query-4/src/SuspenseInfiniteQuery.test-d.tsx index 9b5c47a77..1db5b9b8b 100644 --- a/packages/react-query-4/src/SuspenseInfiniteQuery.test-d.tsx +++ b/packages/react-query-4/src/SuspenseInfiniteQuery.test-d.tsx @@ -7,7 +7,7 @@ import { SuspenseInfiniteQuery } from './SuspenseInfiniteQuery' import type { UseSuspenseInfiniteQueryResult } from './useSuspenseInfiniteQuery' describe('', () => { - it('type error', () => { + it('type check', () => { ;() => ( ', () => { {(query) => <>{query.data.pages.filter(({ text }) => text)}} ) - }) - - it('type check', () => { ;() => ( {(query) => { diff --git a/packages/react-query-4/src/SuspenseQuery.test-d.tsx b/packages/react-query-4/src/SuspenseQuery.test-d.tsx index f84500fdd..1fabc1b32 100644 --- a/packages/react-query-4/src/SuspenseQuery.test-d.tsx +++ b/packages/react-query-4/src/SuspenseQuery.test-d.tsx @@ -6,7 +6,7 @@ import { SuspenseQuery } from './SuspenseQuery' import type { UseSuspenseQueryResult } from './useSuspenseQuery' describe('', () => { - it('type error', () => { + it('type check', () => { ;() => ( ', () => { {(query) => <>{query.data.text}} ) - }) - - it('type check', () => { ;() => ( {(query) => { diff --git a/packages/react-query-4/src/useSuspenseInfiniteQuery.test-d.ts b/packages/react-query-4/src/useSuspenseInfiniteQuery.test-d.ts index 194c831d6..8e3957ec5 100644 --- a/packages/react-query-4/src/useSuspenseInfiniteQuery.test-d.ts +++ b/packages/react-query-4/src/useSuspenseInfiniteQuery.test-d.ts @@ -4,7 +4,7 @@ import { infiniteQueryOptions } from './infiniteQueryOptions' import { type UseSuspenseInfiniteQueryResult, useSuspenseInfiniteQuery } from './useSuspenseInfiniteQuery' describe('useSuspenseInfiniteQuery', () => { - it('type error', () => { + it('type check', () => { // @ts-expect-error no arg useSuspenseInfiniteQuery() @@ -37,9 +37,7 @@ describe('useSuspenseInfiniteQuery', () => { queryFn, // @ts-expect-error no isPlaceholderData }).isPlaceholderData - }) - it('type check', () => { const infiniteQuery = useSuspenseInfiniteQuery({ queryKey, queryFn }) expectTypeOf(infiniteQuery).toEqualTypeOf>() expectTypeOf(infiniteQuery.data).toEqualTypeOf>() diff --git a/packages/react-query-4/src/useSuspenseQueries.test-d.ts b/packages/react-query-4/src/useSuspenseQueries.test-d.ts index d23302110..93a4892be 100644 --- a/packages/react-query-4/src/useSuspenseQueries.test-d.ts +++ b/packages/react-query-4/src/useSuspenseQueries.test-d.ts @@ -5,7 +5,7 @@ import { useSuspenseQueries } from './useSuspenseQueries' import type { UseSuspenseQueryResult } from './useSuspenseQuery' describe('useSuspenseQueries', () => { - it('type error', () => { + it('type check', () => { useSuspenseQueries({ queries: [ { @@ -45,9 +45,7 @@ describe('useSuspenseQueries', () => { useSuspenseQueries({}) // @ts-expect-error if no items useSuspenseQueries() - }) - it('type check', () => { const [query, selectedQuery, selectedQueryByQueryOptions] = useSuspenseQueries({ queries: [ { queryKey: [...queryKey, 5] as const, queryFn }, diff --git a/packages/react-query-4/src/useSuspenseQuery.test-d.ts b/packages/react-query-4/src/useSuspenseQuery.test-d.ts index c230e00bd..61fbf53b1 100644 --- a/packages/react-query-4/src/useSuspenseQuery.test-d.ts +++ b/packages/react-query-4/src/useSuspenseQuery.test-d.ts @@ -4,7 +4,7 @@ import { queryOptions } from './queryOptions' import { type UseSuspenseQueryResult, useSuspenseQuery } from './useSuspenseQuery' describe('useSuspenseQuery', () => { - it('type error', () => { + it('type check', () => { //@ts-expect-error no arg useSuspenseQuery() useSuspenseQuery({ @@ -36,9 +36,7 @@ describe('useSuspenseQuery', () => { queryFn, //@ts-expect-error no isPlaceholderData }).isPlaceholderData - }) - it('type check', () => { const result = useSuspenseQuery({ queryKey, queryFn }) expectTypeOf(result).toEqualTypeOf>() expectTypeOf(result.data).toEqualTypeOf<{ text: string }>() diff --git a/packages/react-query-5/src/SuspenseInfiniteQuery.test-d.tsx b/packages/react-query-5/src/SuspenseInfiniteQuery.test-d.tsx index 1d66d1dd3..f45ad8a08 100644 --- a/packages/react-query-5/src/SuspenseInfiniteQuery.test-d.tsx +++ b/packages/react-query-5/src/SuspenseInfiniteQuery.test-d.tsx @@ -5,7 +5,7 @@ import { describe, expectTypeOf, it } from 'vitest' import { SuspenseInfiniteQuery } from './SuspenseInfiniteQuery' describe('', () => { - it('type error', () => { + it('type check', () => { ;() => ( ', () => { {(query) => <>{query.data.pages.filter(({ text }) => text)}} ) - }) - - it('type check', () => { ;() => ( ', () => { - it('type error', () => { + it('type check', () => { ;() => ( ', () => { {(query) => <>{query.data.text}} ) - }) - - it('type check', () => { ;() => ( {(query) => { diff --git a/packages/utils/src/OmitKeyof.test-d.ts b/packages/utils/src/OmitKeyof.test-d.ts index 14a0900f8..a3a78a3ae 100644 --- a/packages/utils/src/OmitKeyof.test-d.ts +++ b/packages/utils/src/OmitKeyof.test-d.ts @@ -26,7 +26,7 @@ describe('OmitKeyof', () => { // @ts-expect-error Type does not satisfy the constraint keyof A 'z' | 'y' > - >().toEqualTypeOf + >().toEqualTypeOf() expectTypeOf< OmitKeyof< A, @@ -36,7 +36,7 @@ describe('OmitKeyof', () => { // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-arguments 'strictly' > - >().toEqualTypeOf + >().toEqualTypeOf() // 2. safely expectTypeOf< @@ -46,7 +46,7 @@ describe('OmitKeyof', () => { // @ts-expect-error Type does not satisfy the constraint keyof A 'z' | 'y' > - >().toEqualTypeOf + >().toEqualTypeOf() expectTypeOf< OmitKeyof< A, @@ -54,7 +54,7 @@ describe('OmitKeyof', () => { 'z' | 'y', 'safely' > - >().toEqualTypeOf + >().toEqualTypeOf() }) it("'s number key type check", () => { @@ -82,7 +82,7 @@ describe('OmitKeyof', () => { // @ts-expect-error Type does not satisfy the constraint keyof A 3 | 2 > - >().toEqualTypeOf + >().toEqualTypeOf() expectTypeOf< OmitKeyof< A, @@ -92,7 +92,7 @@ describe('OmitKeyof', () => { // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-arguments 'strictly' > - >().toEqualTypeOf + >().toEqualTypeOf() // 2. safely expectTypeOf< @@ -102,7 +102,7 @@ describe('OmitKeyof', () => { // @ts-expect-error Type does not satisfy the constraint keyof A 3 | 2 > - >().toEqualTypeOf + >().toEqualTypeOf() expectTypeOf< OmitKeyof< A, @@ -110,7 +110,7 @@ describe('OmitKeyof', () => { 3 | 2, 'safely' > - >().toEqualTypeOf + >().toEqualTypeOf() }) it("'s symbol key type check", () => { @@ -142,7 +142,7 @@ describe('OmitKeyof', () => { // @ts-expect-error Type does not satisfy the constraint keyof A typeof symbol3 | typeof symbol2 > - >().toEqualTypeOf + >().toEqualTypeOf() expectTypeOf< OmitKeyof< A, @@ -152,7 +152,7 @@ describe('OmitKeyof', () => { // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-arguments 'strictly' > - >().toEqualTypeOf + >().toEqualTypeOf() // 2. safely expectTypeOf< @@ -162,7 +162,7 @@ describe('OmitKeyof', () => { // @ts-expect-error Type does not satisfy the constraint keyof A typeof symbol3 | typeof symbol2 > - >().toEqualTypeOf + >().toEqualTypeOf() expectTypeOf< OmitKeyof< A, @@ -170,6 +170,6 @@ describe('OmitKeyof', () => { typeof symbol3 | typeof symbol2, 'safely' > - >().toEqualTypeOf + >().toEqualTypeOf() }) })