Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract duplicate implementation of InfoHash struct #360

Closed
josecelano opened this issue Aug 4, 2023 · 2 comments · Fixed by #1066
Closed

Extract duplicate implementation of InfoHash struct #360

josecelano opened this issue Aug 4, 2023 · 2 comments · Fixed by #1066
Assignees
@josecelano
Labels
- Developer - Torrust Improvement Experience Build | Project System Compiling and Packaging Code Cleanup / Refactoring Tidying and Making Neat
Milestone
v3.1.0

Comments

@josecelano
Copy link
Member

josecelano commented Aug 4, 2023 •
edited
Loading

Relates to:

We are duplicating code for:

pub struct InfoHash(pub [u8; 20]);

We should extract a common BitTorrent protocol crate for both the Tracker and the Index Backend.
@josecelano josecelano mentioned this issue Aug 4, 2023
Closed
@josecelano josecelano mentioned this issue Oct 9, 2023
Closed
@si14 si14 mentioned this issue Oct 9, 2023
Merged
@da2ce7 da2ce7 added Code Cleanup / Refactoring Tidying and Making Neat - Developer - Torrust Improvement Experience Build | Project System Compiling and Packaging labels Oct 10, 2023
@cgbosse cgbosse moved this to Maintenance in Torrust Solution Jan 8, 2024
@cgbosse cgbosse added this to the v3.0.0 milestone Jan 16, 2024
@josecelano josecelano modified the milestones: v3.0.0, v3.1.0 Feb 27, 2024
@josecelano josecelano modified the milestones: v3.1.0, v3.0.0 Jun 12, 2024
@josecelano josecelano self-assigned this Jun 19, 2024
@josecelano
Copy link
Member Author

Hi @da2ce7 I would like to do this. Which package could we include this mod in? bittorrent?

@cgbosse cgbosse modified the milestones: v3.0.0, v3.1.0 Jul 3, 2024
@josecelano
Copy link
Member Author

I'm extracting the info-hash mod into a new crate:

https://github.com/torrust/bittorrent-primitives

The info-hash mod in the Tracker is newer than the one in the Index. Later on, I will replace the info-hash mod in the Index with this new extracted version.

@josecelano josecelano linked a pull request Oct 30, 2024 that will close this issue
Refactor: extract duplicate implementation of InfoHash struct #1066
Merged
@josecelano josecelano mentioned this issue Oct 30, 2024
Merged
@github-project-automation github-project-automation bot moved this from Maintenance to Done in Torrust Solution Oct 31, 2024
josecelano added a commit to torrust/torrust-index that referenced this issue Oct 31, 2024
@josecelano
Merge #756: Refactor: extract duplicate implementation of InfoHash …
c34b665 
…struct

569fbd2 chore: remove unused dep binascii (Jose Celano)
e58b314 refactor: replace InfoHash with external extracted crate (Jose Celano)
912715f feat: add dep bittorrent-primitives (Jose Celano)

Pull request description:

  Relates to:
    - torrust/torrust-tracker#360
    - torrust/torrust-tracker#1066

  The `InfoHash` type was duplicated here and in the [Tracker](torrust/torrust-tracker#360). I've extracted it into a new crate:

  https://github.com/torrust/bittorrent-primitives

ACKs for top commit:
  josecelano:
    ACK 569fbd2

Tree-SHA512: a09f849555067a08efe4609c68d38ca690ef7d3d795b81deeb3b6aa8f2cfa235082620745835f26155b80076a78f23c8eb99f46dbfb46a5da67a9c8b54c64691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josecelano josecelano

Labels
- Developer - Torrust Improvement Experience Build | Project System Compiling and Packaging Code Cleanup / Refactoring Tidying and Making Neat
Projects
Torrust Solution
Status: Done
Milestone
v3.1.0
Development

Successfully merging a pull request may close this issue.

Refactor: extract duplicate implementation of InfoHash struct josecelano/torrust-tracker
3 participants
@josecelano @da2ce7 @cgbosse