Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul stats: add a configuration option to enable/disable stats per server #1401

Closed
Tracked by #1263
josecelano opened this issue Mar 20, 2025 · 0 comments · Fixed by #1402
Closed
Tracked by #1263

Overhaul stats: add a configuration option to enable/disable stats per server #1401

josecelano opened this issue Mar 20, 2025 · 0 comments · Fixed by #1402
Assignees

Comments

@josecelano
Copy link
Member

josecelano commented Mar 20, 2025

This feature is not implemented yet. In fact this is the first step. I want to add a new config option to enable/disable stats for each service (associated to a socket address).

[core]
tracker_usage_statistics = true

[[udp_trackers]]
bind_address = "0.0.0.0:6969"
tracker_usage_statistics = true  <- the new option

  [udp_trackers.cookie_lifetime]
  secs = 120
  nanos = 0

[[http_trackers]]
bind_address = "0.0.0.0:7070"
tracker_usage_statistics = true

[http_api]
bind_address = "0.0.0.0:1212"

  [http_api.access_tokens]
  admin = "***"

[health_check_api]
bind_address = "127.0.0.1:1313"
  • I will use the same name we are using for the global metrics: tracker_usage_statistics.
  • The default value will be false.
  • For the time being, events are only used for stats even if they are already decoupled from stats. But for this issue and the parent issue we will continue enabling events when stats are enabled. We will introduce a new config option in the future to enable events even if you want to disable stats (why? because you might want to build your own stats).

This new config option will have no effect until the feature is implemented.

@josecelano josecelano self-assigned this Mar 20, 2025
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 21, 2025
…usage stats per server

It does not have any effect yet.
josecelano added a commit that referenced this issue Mar 21, 2025
…able stats per server

57d884d refactor: [#1401] add config option to enable/disable tracker usage stats per server (Jose Celano)

Pull request description:

  Add a configuration option to enable/disable stats per server. It does not have any effect yet.

ACKs for top commit:
  josecelano:
    ACK 57d884d

Tree-SHA512: 292f82fe1e505ea4c7f485ce46ff7356ba96ebd2e9ed5d548da5532d9e75b41eb011f25fd31f467237fd8652faaad0dcf12360d18a1c166059e49350a3f6cc25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant