Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul stats: Increase IPv4 stats for IPv6 IPs with the prefix ::ffff: #1375

Open
josecelano opened this issue Mar 12, 2025 · 0 comments
Open
Assignees
Labels
- User - Enjoyable to Use our Software Breaking Change Breaking change Enhancement / Feature Request Something New

Comments

@josecelano
Copy link
Member

Relates to: #1368

When you bind the server socket address to IPv6 IP addresses ([::]:6969 in the bind_address config option), the tracker can handle requests from IPv4 and IPv6 clients. IPv4 clients' addresses are converted to IPv6 IPs.

However, the metrics are increased for IPv6. I think we can add a config option to change the behaviour and increase IPv4-related metrics when the IPv6 address has the ::ffff: prefix.

I would make it the default behaviour, but that's a breaking change. So the new config option should be disabled.

IPv4-mapped notation

Image

cc @da2ce7 @devnakx

@josecelano josecelano added - User - Enjoyable to Use our Software Breaking Change Breaking change Enhancement / Feature Request Something New labels Mar 12, 2025
@josecelano josecelano changed the title Overhaul stats events: increase IPv4 stats for IPv6 IPs with the prefix ::ffff: Overhaul stats: increase IPv4 stats for IPv6 IPs with the prefix ::ffff: Mar 12, 2025
@josecelano josecelano self-assigned this Mar 12, 2025
@josecelano josecelano changed the title Overhaul stats: increase IPv4 stats for IPv6 IPs with the prefix ::ffff: Overhaul stats: Increase IPv4 stats for IPv6 IPs with the prefix ::ffff: Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- User - Enjoyable to Use our Software Breaking Change Breaking change Enhancement / Feature Request Something New
Projects
None yet
Development

No branches or pull requests

1 participant