You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/// > **NOTICE**: as the HTTP tracker does not requires a connection request/// > like the UDP tracker, the number of TCP connections is incremented for/// > each `announce` request.
The HTTP tracker core keeps a counter for the number of connections handled. However that metrics does not make sense. Internally the counter is the number of announce requests plus the number of scrape requests.
pubstructMetrics{/// Total number of TCP (HTTP tracker) connections from IPv4 peers./// Since the HTTP tracker spec does not require a handshake, this metric/// increases for every HTTP request.pubtcp4_connections_handled:u64,/// Total number of TCP (HTTP tracker) `announce` requests from IPv4 peers.pubtcp4_announces_handled:u64,/// Total number of TCP (HTTP tracker) `scrape` requests from IPv4 peers.pubtcp4_scrapes_handled:u64,/// Total number of TCP (HTTP tracker) connections from IPv6 peers.pubtcp6_connections_handled:u64,/// Total number of TCP (HTTP tracker) `announce` requests from IPv6 peers.pubtcp6_announces_handled:u64,/// Total number of TCP (HTTP tracker) `scrape` requests from IPv6 peers.pubtcp6_scrapes_handled:u64,}
I think it would make sense to delete those counters and add new counter to the axum-http-tracker-server package:
tcp4_requests
tcp6_requests
The udp-tracker-server has those metrics and also:
tcp4_responses
tcp6_responses
The text was updated successfully, but these errors were encountered:
The number of HTTP tracker connections don't make sense. There are
connection requests only in the UDP tracker.
That code is removed but, in order to keep backward compatibility, the
API still exposes that value which is the:
number of announce requests + number of scrape requests
89607cc refactor: [#1342] remove counter for HTTP connetions internally (Jose Celano)
Pull request description:
The number of HTTP tracker connections don't make sense. There are connection requests only in the UDP tracker.
That code is removed but, in order to keep backward compatibility, the API still exposes that value which is the:
number of announce requests + number of scrape requests
ACKs for top commit:
josecelano:
ACK 89607cc
Tree-SHA512: 066132e56f5e7e14050d78a15981c07f79acfe0b11903da35f15ca4214d16873799479f0aa98bb767eb23b496988e808d3f1ab1544b78ab072393711f28598b7
There are a couple of comments like this:
The HTTP tracker core keeps a counter for the number of connections handled. However that metrics does not make sense. Internally the counter is the number of announce requests plus the number of scrape requests.
I think it would make sense to delete those counters and add new counter to the
axum-http-tracker-server
package:tcp4_requests
tcp6_requests
The
udp-tracker-server
has those metrics and also:tcp4_responses
tcp6_responses
The text was updated successfully, but these errors were encountered: