Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor packages: clean announce and scrape handlers #1338

Closed
josecelano opened this issue Mar 3, 2025 · 0 comments · Fixed by #1339
Closed

Refactor packages: clean announce and scrape handlers #1338

josecelano opened this issue Mar 3, 2025 · 0 comments · Fixed by #1339
Assignees
@josecelano
Labels
- Developer - Torrust Improvement Experience

Comments

@josecelano
Copy link
Member

Clean announce and scrape handlers:

  • Extract methods
  • Rearrange code
  • ...
@josecelano josecelano added the - Developer - Torrust Improvement Experience label Mar 3, 2025
@josecelano josecelano self-assigned this Mar 3, 2025
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 3, 2025
@josecelano
refactor: [torrust#1338] clean bittorrent_http_tracker_core::services…
ec0e437 
…::announce::AnnounceService
@josecelano josecelano linked a pull request Mar 3, 2025 that will close this issue
Refactor packages: clean announce and scrape handlers #1339
Merged
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 3, 2025
@josecelano
refactor: [torrust#1338] rearrange code
1b01bf0
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 3, 2025
@josecelano
refactor: [torrust#1338] bittorrent_http_tracker_core::services::scra…
a426259 
…pe::ScrapeService
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 3, 2025
@josecelano
refactor: [torrust#1338] clean bittorrent_udp_tracker_core::services:…
9326da3 
…:announce::AnnunceService
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 3, 2025
@josecelano
refactor: [torrust#1338] clean bittorrent_udp_tracker_core::services:…
f9a7bfd 
…:scrape::ScrapeService
josecelano added a commit that referenced this issue Mar 3, 2025
@josecelano
Merge #1339: Refactor packages: clean announce and scrape handlers
4d9787d 
f9a7bfd refactor: [#1338] clean bittorrent_udp_tracker_core::services::scrape::ScrapeService (Jose Celano)
3c4dcdb refactor: rearrange code (Jose Celano)
9326da3 refactor: [#1338] clean bittorrent_udp_tracker_core::services::announce::AnnunceService (Jose Celano)
0fce925 chore: remove deprecated clippy attribute (Jose Celano)
bb6af4d refactor: make service fields private (Jose Celano)
2a7e2cb refactor: rearrange code (Jose Celano)
a426259 refactor: [#1338] bittorrent_http_tracker_core::services::scrape::ScrapeService (Jose Celano)
1b01bf0 refactor: [#1338] rearrange code (Jose Celano)
ec0e437 refactor: [#1338] clean bittorrent_http_tracker_core::services::announce::AnnounceService (Jose Celano)
5178aba fix: clippy error (Jose Celano)
29344b1 refactor: rearrange code (Jose Celano)

Pull request description:

  Clean `announce` and `scrape` handlers:

  - Extract methods.
  - Rearrange code.
  - Etc.

ACKs for top commit:
  josecelano:
    ACK f9a7bfd

Tree-SHA512: 5552296df9e577d18cc306791e22b9a5dba47229461de28abef0d66bf93d5b6d036027e681f7deb45ebb878c1f521b5a511f45b0abb6372c63e4deeca71aded9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josecelano josecelano

Labels
- Developer - Torrust Improvement Experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor packages: clean announce and scrape handlers josecelano/torrust-tracker
1 participant
@josecelano