Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract torrust-tracker-api-client workspace package #1159

Closed
josecelano opened this issue Dec 26, 2024 · 0 comments · Fixed by #1179
Closed

Extract torrust-tracker-api-client workspace package #1159

josecelano opened this issue Dec 26, 2024 · 0 comments · Fixed by #1179
Assignees
@josecelano
Labels
Code Cleanup / Refactoring Tidying and Making Neat

Comments

@josecelano
Copy link
Member

Parent issue: #753

Dir: packages/tracker-api-client
Crate:: torrust-tracker-api-client
@josecelano josecelano added the Code Cleanup / Refactoring Tidying and Making Neat label Dec 26, 2024
@josecelano josecelano self-assigned this Dec 26, 2024
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 10, 2025
@josecelano
feat: [torrust#1159] extract new packate tracker api client
09ec5b2
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 10, 2025
@josecelano
feat: [torrust#1159] extract new package tracker api client
a1ded65
@josecelano josecelano linked a pull request Jan 10, 2025 that will close this issue
Extract new package: Tracker API client #1179
Merged
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 10, 2025
@josecelano
refactor: [torrust#1159] use new tracker api client package in tests
99fcbb6 
The Tracker API client was extracted into a new package. This removes
the duplicate client in tests and starts using the new package.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 10, 2025
@josecelano
refactor: [torrust#1159] use new tracker api client package in tests
e4b9875 
The Tracker API client was extracted into a new package. This removes
the duplicate client in tests and starts using the new package.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 10, 2025
@josecelano
refactor: [torrust#1159] API client. Extract Origin type
b6abf2b 
Instead of using a plain string we now use a Origin type containing hte
base URL for the API without path or fragments.

```
scheme://host:port/
```
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 10, 2025
@josecelano
refactor: [torrust#1159] API client. Extract Origin type
b47cc0a 
Instead of using a plain string we now use a Origin type containing hte
base URL for the API without path or fragments.

```
scheme://host:port/
```
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 10, 2025
@josecelano
refactor: [torrust#1159] API client. Extract Origin type
aa7ffdf 
Instead of using a plain string we now use a Origin type containing hte
base URL for the API without path or fragments.

```
scheme://host:port/
```
@josecelano josecelano changed the title Extract tracker-tracker-api-client workspace package Extract torrust-tracker-api-client workspace package Jan 10, 2025
josecelano added a commit that referenced this issue Jan 10, 2025
@josecelano
Merge #1179: Extract new package: Tracker API client
f508ef7 
aa7ffdf refactor: [#1159] API client. Extract Origin type (Jose Celano)
e4b9875 refactor: [#1159] use new tracker api client package in tests (Jose Celano)
a1ded65 feat: [#1159] extract new package tracker api client (Jose Celano)

Pull request description:

  Extract new package: Tracker API client.

  I've also extracted a new type `Origin` for the API base URL in the connection info. For example: `htpp://tracker.com:1212/`.

ACKs for top commit:
  josecelano:
    ACK aa7ffdf

Tree-SHA512: a079411fe0928d719f61a827e87ee7a323dc4609031dd3872a6d308df81c8c2cc01b951f92288bb670a3a75977c153679d73f81aa2e4802c82909e97bb20bb63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josecelano josecelano

Labels
Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract new package: Tracker API client josecelano/torrust-tracker
1 participant
@josecelano