Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider config option to ignore connection ID expiration in UDP tracker #1136

Open
josecelano opened this issue Dec 17, 2024 · 1 comment
Open

Comments

@josecelano
Copy link
Member

Relates to:

We have recently implemented an IP ban service to ban IPs that are not sending the correct connection ID for the UDP tracker.

Initially, we thought it was a DDoS attack or spam, but it seems to be a common problem. It seems there are some BitTorrent clients that do not implement the UDP specification correctly.

image

Some people have reported bad clients even increasing the expiration for the connection ID to 2 hours. That probably means some clients don't care at all about the connection ID, presumably because some trackers don't care either.

We could add a configuration option to increase that limit, but I would prefer to strcitly follow the specification.

cc @da2ce7

@josecelano
Copy link
Member Author

I did not remember (because it was added by @da2ce7) there is already a configuration option to increase the lifetime of the cookie:

[[udp_trackers]]
bind_address = "0.0.0.0:6969"

  [udp_trackers.cookie_lifetime]
  secs = 120
  nanos = 0

@da2ce7 suggested to add a flag to ignore connection ID on the weekly meeting.

[[udp_trackers]]
bind_address = "0.0.0.0:6969"
connection_id_validation_enabled = true # deafults to `true`

  [udp_trackers.cookie_lifetime]
  secs = 120
  nanos = 0

@josecelano josecelano changed the title Consider config option to increase connection ID expiration in UDP tracker Consider config option to ignore connection ID expiration in UDP tracker Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant