refactor: [#1191] replace authentication methods with extracted service in the core tracker

Author: josecelano

src/app_test.rs

@@ -5,8 +5,8 @@ use torrust_tracker_configuration::Configuration;
 
 use crate::core::databases::Database;
 use crate::core::services::initialize_database;
-use crate::core::whitelist;
 use crate::core::whitelist::repository::in_memory::InMemoryWhitelist;
+use crate::core::{authentication, whitelist};
 
 /// Initialize the tracker dependencies.
 #[allow(clippy::type_complexity)]
@@ -17,13 +17,15 @@ pub fn initialize_tracker_dependencies(
     Arc<Box<dyn Database>>,
     Arc<InMemoryWhitelist>,
     Arc<whitelist::authorization::Authorization>,
+    Arc<authentication::Facade>,
 ) {
     let database = initialize_database(config);
     let in_memory_whitelist = Arc::new(InMemoryWhitelist::default());
     let whitelist_authorization = Arc::new(whitelist::authorization::Authorization::new(
         &config.core,
         &in_memory_whitelist.clone(),
     ));
+    let authentication = Arc::new(authentication::Facade::new(&config.core, &database.clone()));
 
-    (database, in_memory_whitelist, whitelist_authorization)
+    (database, in_memory_whitelist, whitelist_authorization, authentication)
 }

src/bootstrap/app.rs

@@ -23,8 +23,8 @@ use super::config::initialize_configuration;
 use crate::bootstrap;
 use crate::container::AppContainer;
 use crate::core::services::{initialize_database, initialize_tracker, initialize_whitelist_manager, statistics};
-use crate::core::whitelist;
 use crate::core::whitelist::repository::in_memory::InMemoryWhitelist;
+use crate::core::{authentication, whitelist};
 use crate::servers::udp::server::banning::BanService;
 use crate::servers::udp::server::launcher::MAX_CONNECTION_ID_ERRORS_PER_IP;
 use crate::shared::crypto::ephemeral_instance_keys;
@@ -89,8 +89,14 @@ pub fn initialize_app_container(configuration: &Configuration) -> AppContainer {
         &in_memory_whitelist.clone(),
     ));
     let whitelist_manager = initialize_whitelist_manager(database.clone(), in_memory_whitelist.clone());
+    let authentication = Arc::new(authentication::Facade::new(&configuration.core, &database.clone()));
 
-    let tracker = Arc::new(initialize_tracker(configuration, &database, &whitelist_authorization));
+    let tracker = Arc::new(initialize_tracker(
+        configuration,
+        &database,
+        &whitelist_authorization,
+        &authentication,
+    ));
 
     AppContainer {
         tracker,
@@ -99,6 +105,7 @@ pub fn initialize_app_container(configuration: &Configuration) -> AppContainer {
         stats_event_sender,
         stats_repository,
         whitelist_manager,
+        authentication,
     }
 }
 

src/bootstrap/jobs/http_tracker.rs

@@ -101,8 +101,8 @@ mod tests {
     use crate::bootstrap::app::initialize_global_services;
     use crate::bootstrap::jobs::http_tracker::start_job;
     use crate::core::services::{initialize_database, initialize_tracker, statistics};
-    use crate::core::whitelist;
     use crate::core::whitelist::repository::in_memory::InMemoryWhitelist;
+    use crate::core::{authentication, whitelist};
     use crate::servers::http::Version;
     use crate::servers::registar::Registar;
 
@@ -123,7 +123,9 @@ mod tests {
             &cfg.core,
             &in_memory_whitelist.clone(),
         ));
-        let tracker = Arc::new(initialize_tracker(&cfg, &database, &whitelist_authorization));
+        let authentication = Arc::new(authentication::Facade::new(&cfg.core, &database.clone()));
+
+        let tracker = Arc::new(initialize_tracker(&cfg, &database, &whitelist_authorization, &authentication));
 
         let version = Version::V1;
 

src/bootstrap/jobs/tracker_apis.rs

@@ -150,8 +150,8 @@ mod tests {
     use crate::bootstrap::app::initialize_global_services;
     use crate::bootstrap::jobs::tracker_apis::start_job;
     use crate::core::services::{initialize_database, initialize_tracker, initialize_whitelist_manager, statistics};
-    use crate::core::whitelist;
     use crate::core::whitelist::repository::in_memory::InMemoryWhitelist;
+    use crate::core::{authentication, whitelist};
     use crate::servers::apis::Version;
     use crate::servers::registar::Registar;
     use crate::servers::udp::server::banning::BanService;
@@ -176,8 +176,9 @@ mod tests {
             &in_memory_whitelist.clone(),
         ));
         let whitelist_manager = initialize_whitelist_manager(database.clone(), in_memory_whitelist.clone());
+        let authentication = Arc::new(authentication::Facade::new(&cfg.core, &database.clone()));
 
-        let tracker = Arc::new(initialize_tracker(&cfg, &database, &whitelist_authorization));
+        let tracker = Arc::new(initialize_tracker(&cfg, &database, &whitelist_authorization, &authentication));
 
         let version = Version::V1;
 

src/container.rs

@@ -5,7 +5,7 @@ use tokio::sync::RwLock;
 use crate::core::statistics::event::sender::Sender;
 use crate::core::statistics::repository::Repository;
 use crate::core::whitelist::manager::WhiteListManager;
-use crate::core::{whitelist, Tracker};
+use crate::core::{authentication, whitelist, Tracker};
 use crate::servers::udp::server::banning::BanService;
 
 pub struct AppContainer {
@@ -15,4 +15,5 @@ pub struct AppContainer {
     pub stats_event_sender: Arc<Option<Box<dyn Sender>>>,
     pub stats_repository: Arc<Repository>,
     pub whitelist_manager: Arc<WhiteListManager>,
+    pub authentication: Arc<authentication::Facade>,
 }

src/core/authentication/mod.rs

@@ -81,7 +81,7 @@ impl Facade {
     /// # Errors
     ///
     /// Will return a `key::Error` if unable to get any `auth_key`.
-    async fn verify_auth_key(&self, key: &Key) -> Result<(), Error> {
+    pub async fn verify_auth_key(&self, key: &Key) -> Result<(), Error> {
         match self.keys.read().await.get(key) {
             None => Err(Error::UnableToReadKey {
                 location: Location::caller(),
@@ -268,10 +268,17 @@ impl Facade {
     /// Will return a `database::Error` if unable to remove the `key` to the database.
     pub async fn remove_auth_key(&self, key: &Key) -> Result<(), databases::error::Error> {
         self.database.remove_key_from_keys(key)?;
-        self.keys.write().await.remove(key);
+        self.remove_in_memory_auth_key(key).await;
         Ok(())
     }
 
+    /// It removes an authentication key from memory.
+    ///
+    /// # Context: Authentication    
+    pub async fn remove_in_memory_auth_key(&self, key: &Key) {
+        self.keys.write().await.remove(key);
+    }
+
     /// The `Tracker` stores the authentication keys in memory and in the database.
     /// In case you need to restart the `Tracker` you can load the keys from the database
     /// into memory with this function. Keys are automatically stored in the database when they