Skip to content

Commit 239f352

Browse files
committed
refactor: encapsule field TrackerCoreContainer in UdpTrackerCoreContainer
1 parent 0d42586 commit 239f352

File tree

4 files changed

+5
-21
lines changed

4 files changed

+5
-21
lines changed

packages/udp-tracker-core/src/container.rs

+2-14
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
use std::sync::Arc;
22

3-
use bittorrent_tracker_core::announce_handler::AnnounceHandler;
43
use bittorrent_tracker_core::container::TrackerCoreContainer;
5-
use bittorrent_tracker_core::scrape_handler::ScrapeHandler;
6-
use bittorrent_tracker_core::whitelist;
74
use tokio::sync::RwLock;
85
use torrust_tracker_configuration::{Core, UdpTracker};
96

@@ -14,12 +11,7 @@ use crate::services::scrape::ScrapeService;
1411
use crate::{event, statistics, MAX_CONNECTION_ID_ERRORS_PER_IP};
1512

1613
pub struct UdpTrackerCoreContainer {
17-
// todo: replace with TrackerCoreContainer
18-
pub core_config: Arc<Core>,
19-
pub announce_handler: Arc<AnnounceHandler>,
20-
pub scrape_handler: Arc<ScrapeHandler>,
21-
pub whitelist_authorization: Arc<whitelist::authorization::WhitelistAuthorization>,
22-
14+
pub tracker_core_container: Arc<TrackerCoreContainer>,
2315
pub udp_tracker_config: Arc<UdpTracker>,
2416
pub udp_core_stats_event_sender: Arc<Option<Box<dyn event::sender::Sender>>>,
2517
pub udp_core_stats_repository: Arc<statistics::repository::Repository>,
@@ -58,11 +50,7 @@ impl UdpTrackerCoreContainer {
5850
));
5951

6052
Arc::new(UdpTrackerCoreContainer {
61-
core_config: tracker_core_container.core_config.clone(),
62-
announce_handler: tracker_core_container.announce_handler.clone(),
63-
scrape_handler: tracker_core_container.scrape_handler.clone(),
64-
whitelist_authorization: tracker_core_container.whitelist_authorization.clone(),
65-
53+
tracker_core_container: tracker_core_container.clone(),
6654
udp_tracker_config: udp_tracker_config.clone(),
6755
udp_core_stats_event_sender: udp_core_stats_event_sender.clone(),
6856
udp_core_stats_repository: udp_core_stats_repository.clone(),

packages/udp-tracker-server/src/handlers/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ pub async fn handle_request(
172172
client_socket_addr,
173173
server_socket_addr,
174174
&announce_request,
175-
&udp_tracker_core_container.core_config,
175+
&udp_tracker_core_container.tracker_core_container.core_config,
176176
&udp_tracker_server_container.udp_server_stats_event_sender,
177177
cookie_time_values.valid_range,
178178
)

packages/udp-tracker-server/src/server/launcher.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ impl Launcher {
4747
) {
4848
tracing::info!(target: UDP_TRACKER_LOG_TARGET, "Starting on: {bind_to}");
4949

50-
if udp_tracker_core_container.core_config.private {
50+
if udp_tracker_core_container.tracker_core_container.core_config.private {
5151
tracing::error!("udp services cannot be used for private trackers");
5252
panic!("it should not use udp if using authentication");
5353
}

src/container.rs

+1-5
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,7 @@ impl AppContainer {
135135
#[must_use]
136136
pub fn udp_tracker_container(&self, udp_tracker_config: &Arc<UdpTracker>) -> UdpTrackerCoreContainer {
137137
UdpTrackerCoreContainer {
138-
core_config: self.tracker_core_container.core_config.clone(),
139-
announce_handler: self.tracker_core_container.announce_handler.clone(),
140-
scrape_handler: self.tracker_core_container.scrape_handler.clone(),
141-
whitelist_authorization: self.tracker_core_container.whitelist_authorization.clone(),
142-
138+
tracker_core_container: self.tracker_core_container.clone(),
143139
udp_tracker_config: udp_tracker_config.clone(),
144140
udp_core_stats_event_sender: self.udp_core_stats_event_sender.clone(),
145141
udp_core_stats_repository: self.udp_core_stats_repository.clone(),

0 commit comments

Comments
 (0)