refactor: [#1311] move static initialization to the module where the static values are used

This will alllow to initizlize static values in other packages, not only
the main tracker app.

Author: josecelano

Cargo.lock

@@ -52,7 +52,6 @@ figment = "0"
 futures = "0"
 futures-util = "0"
 hyper = "1"
-lazy_static = "1"
 parking_lot = "0"
 percent-encoding = "2"
 r2d2 = "0"

Cargo.toml

@@ -18,6 +18,7 @@ version.workspace = true
 [dependencies]
 chrono = { version = "0", default-features = false, features = ["clock"] }
 lazy_static = "1"
+tracing = "0"
 
 torrust-tracker-primitives = { version = "3.0.0-develop", path = "../primitives" }
 

packages/clock/Cargo.toml

@@ -22,14 +22,15 @@
 //! > **NOTICE**: the timestamp does not depend on the time zone. That gives you
 //! > the ability to use the clock regardless of the underlying system time zone
 //! > configuration. See [Unix time Wikipedia entry](https://en.wikipedia.org/wiki/Unix_time).
-
 pub mod clock;
 pub mod conv;
 pub mod static_time;
 
 #[macro_use]
 extern crate lazy_static;
 
+use tracing::instrument;
+
 /// This code needs to be copied into each crate.
 /// Working version, for production.
 #[cfg(not(test))]
@@ -40,3 +41,16 @@ pub(crate) type CurrentClock = clock::Working;
 #[cfg(test)]
 #[allow(dead_code)]
 pub(crate) type CurrentClock = clock::Stopped;
+
+/// It initializes the application static values.
+///
+/// These values are accessible throughout the entire application:
+///
+/// - The time when the application started.
+/// - An ephemeral instance random seed. This seed is used for encryption and
+///   it's changed when the main application process is restarted.
+#[instrument(skip())]
+pub fn initialize_static() {
+    // Set the time of Torrust app starting
+    lazy_static::initialize(&static_time::TIME_AT_APP_START);
+}

packages/clock/src/lib.rs

@@ -4,6 +4,9 @@ pub mod crypto;
 pub mod services;
 pub mod statistics;
 
+use crypto::ephemeral_instance_keys;
+use tracing::instrument;
+
 #[macro_use]
 extern crate lazy_static;
 
@@ -12,3 +15,16 @@ extern crate lazy_static;
 pub const MAX_CONNECTION_ID_ERRORS_PER_IP: u32 = 10;
 
 pub const UDP_TRACKER_LOG_TARGET: &str = "UDP TRACKER";
+
+/// It initializes the static values.
+#[instrument(skip())]
+pub fn initialize_static() {
+    // Initialize the Ephemeral Instance Random Seed
+    lazy_static::initialize(&ephemeral_instance_keys::RANDOM_SEED);
+
+    // Initialize the Ephemeral Instance Random Cipher
+    lazy_static::initialize(&ephemeral_instance_keys::RANDOM_CIPHER_BLOWFISH);
+
+    // Initialize the Zeroed Cipher
+    lazy_static::initialize(&ephemeral_instance_keys::ZEROED_TEST_CIPHER_BLOWFISH);
+}

packages/udp-tracker-core/src/lib.rs

@@ -11,9 +11,7 @@
 //! 2. Initialize static variables.
 //! 3. Initialize logging.
 //! 4. Initialize the domain tracker.
-use bittorrent_udp_tracker_core::crypto::ephemeral_instance_keys;
 use bittorrent_udp_tracker_core::crypto::keys::{self, Keeper as _};
-use torrust_tracker_clock::static_time;
 use torrust_tracker_configuration::validator::Validator;
 use torrust_tracker_configuration::{logging, Configuration};
 use tracing::instrument;
@@ -71,18 +69,10 @@ pub fn initialize_global_services(configuration: &Configuration) {
 /// These values are accessible throughout the entire application:
 ///
 /// - The time when the application started.
-/// - An ephemeral instance random seed. This seed is used for encryption and it's changed when the main application process is restarted.
+/// - An ephemeral instance random seed. This seed is used for encryption and
+///   it's changed when the main application process is restarted.
 #[instrument(skip())]
 pub fn initialize_static() {
-    // Set the time of Torrust app starting
-    lazy_static::initialize(&static_time::TIME_AT_APP_START);
-
-    // Initialize the Ephemeral Instance Random Seed
-    lazy_static::initialize(&ephemeral_instance_keys::RANDOM_SEED);
-
-    // Initialize the Ephemeral Instance Random Cipher
-    lazy_static::initialize(&ephemeral_instance_keys::RANDOM_CIPHER_BLOWFISH);
-
-    // Initialize the Zeroed Cipher
-    lazy_static::initialize(&ephemeral_instance_keys::ZEROED_TEST_CIPHER_BLOWFISH);
+    torrust_tracker_clock::initialize_static();
+    bittorrent_udp_tracker_core::initialize_static();
 }