dev: tighten lint for build and clippy

da2ce7 · da2ce7 · commit 9de7aa7e5563 · 2023-08-02T17:22:55.000+01:00
diff --git a/.cargo/config.toml b/.cargo/config.toml
@@ -3,3 +3,23 @@ cov = "llvm-cov"
 cov-html = "llvm-cov --html"
 cov-lcov = "llvm-cov --lcov --output-path=./.coverage/lcov.info"
 time = "build --timings --all-targets"
+
+[build]
+rustflags = [
+    "-D",
+    "warnings",
+    "-D",
+    "future-incompatible",
+    "-D",
+    "let-underscore",
+    "-D",
+    "nonstandard-style",
+    "-D",
+    "rust-2018-compatibility",
+    "-D",
+    "rust-2018-idioms",
+    "-D",
+    "rust-2021-compatibility",
+    "-D",
+    "unused",
+]
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -2,7 +2,22 @@
   "[rust]": {
     "editor.formatOnSave": true
   },
-  "rust-analyzer.checkOnSave.command": "clippy",
-  "rust-analyzer.checkOnSave.allTargets": true,
-  "rust-analyzer.checkOnSave.extraArgs": ["--", "-W", "clippy::pedantic"]
-}
+  "rust-analyzer.checkOnSave": true,
+  "rust-analyzer.check.command": "clippy",
+  "rust-analyzer.check.allTargets": true,
+  "rust-analyzer.check.extraArgs": [
+    "--",
+    "-D",
+    "clippy::correctness",
+    "-D",
+    "clippy::suspicious",
+    "-W",
+    "clippy::complexity",
+    "-W",
+    "clippy::perf",
+    "-W",
+    "clippy::style",
+    "-W",
+    "clippy::pedantic",
+  ],
+}
diff --git a/src/app.rs b/src/app.rs
@@ -162,7 +162,7 @@ pub async fn run(configuration: Configuration, api_version: &Version) -> Running
         loop {
             interval.tick().await;
             if let Some(tracker) = weak_tracker_statistics_importer.upgrade() {
-                let _ = tracker.import_all_torrents_statistics().await;
+                drop(tracker.import_all_torrents_statistics().await);
             } else {
                 break;
             }
diff --git a/src/cache/mod.rs b/src/cache/mod.rs
@@ -121,7 +121,7 @@ impl BytesCache {
         }
 
         // Remove the old entry so that a new entry will be added as last in the queue.
-        let _ = self.bytes_table.shift_remove(&key);
+        drop(self.bytes_table.shift_remove(&key));
 
         let bytes_cache_entry = BytesCacheEntry::new(bytes);
 
diff --git a/src/databases/mysql.rs b/src/databases/mysql.rs
@@ -73,7 +73,7 @@ impl Database for Mysql {
 
         // rollback transaction on error
         if let Err(e) = insert_user_auth_result {
-            let _ = tx.rollback().await;
+            drop(tx.rollback().await);
             return Err(e);
         }
 
@@ -100,11 +100,11 @@ impl Database for Mysql {
         // commit or rollback transaction and return user_id on success
         match insert_user_profile_result {
             Ok(_) => {
-                let _ = tx.commit().await;
+                drop(tx.commit().await);
                 Ok(i64::overflowing_add_unsigned(0, user_id).0)
             }
             Err(e) => {
-                let _ = tx.rollback().await;
+                drop(tx.rollback().await);
                 Err(e)
             }
         }
@@ -497,7 +497,7 @@ impl Database for Mysql {
 
         // rollback transaction on error
         if let Err(e) = insert_torrent_files_result {
-            let _ = tx.rollback().await;
+            drop(tx.rollback().await);
             return Err(e);
         }
 
@@ -531,7 +531,7 @@ impl Database for Mysql {
 
         // rollback transaction on error
         if let Err(e) = insert_torrent_announce_urls_result {
-            let _ = tx.rollback().await;
+            drop(tx.rollback().await);
             return Err(e);
         }
 
@@ -558,11 +558,11 @@ impl Database for Mysql {
         // commit or rollback transaction and return user_id on success
         match insert_torrent_info_result {
             Ok(_) => {
-                let _ = tx.commit().await;
+                drop(tx.commit().await);
                 Ok(torrent_id)
             }
             Err(e) => {
-                let _ = tx.rollback().await;
+                drop(tx.rollback().await);
                 Err(e)
             }
         }
diff --git a/src/databases/sqlite.rs b/src/databases/sqlite.rs
@@ -74,7 +74,7 @@ impl Database for Sqlite {
 
         // rollback transaction on error
         if let Err(e) = insert_user_auth_result {
-            let _ = tx.rollback().await;
+            drop(tx.rollback().await);
             return Err(e);
         }
 
@@ -101,11 +101,11 @@ impl Database for Sqlite {
         // commit or rollback transaction and return user_id on success
         match insert_user_profile_result {
             Ok(_) => {
-                let _ = tx.commit().await;
+                drop(tx.commit().await);
                 Ok(user_id)
             }
             Err(e) => {
-                let _ = tx.rollback().await;
+                drop(tx.rollback().await);
                 Err(e)
             }
         }
@@ -487,7 +487,7 @@ impl Database for Sqlite {
 
         // rollback transaction on error
         if let Err(e) = insert_torrent_files_result {
-            let _ = tx.rollback().await;
+            drop(tx.rollback().await);
             return Err(e);
         }
 
@@ -521,7 +521,7 @@ impl Database for Sqlite {
 
         // rollback transaction on error
         if let Err(e) = insert_torrent_announce_urls_result {
-            let _ = tx.rollback().await;
+            drop(tx.rollback().await);
             return Err(e);
         }
 
@@ -548,11 +548,11 @@ impl Database for Sqlite {
         // commit or rollback transaction and return user_id on success
         match insert_torrent_info_result {
             Ok(_) => {
-                let _ = tx.commit().await;
+                drop(tx.commit().await);
                 Ok(torrent_id)
             }
             Err(e) => {
-                let _ = tx.rollback().await;
+                drop(tx.rollback().await);
                 Err(e)
             }
         }
diff --git a/src/models/info_hash.rs b/src/models/info_hash.rs
@@ -167,7 +167,7 @@ impl InfoHash {
 }
 
 impl std::fmt::Display for InfoHash {
-    fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         let mut chars = [0u8; 40];
         binascii::bin2hex(&self.0, &mut chars).expect("failed to hexlify");
         write!(f, "{}", std::str::from_utf8(&chars).unwrap())
@@ -271,7 +271,7 @@ struct InfoHashVisitor;
 impl<'v> serde::de::Visitor<'v> for InfoHashVisitor {
     type Value = InfoHash;
 
-    fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {
+    fn expecting(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         write!(formatter, "a 40 character long hash")
     }
 
diff --git a/src/services/torrent.rs b/src/services/torrent.rs
@@ -118,10 +118,11 @@ impl Index {
 
         let torrent_id = self.torrent_repository.add(&torrent_request, user_id, category).await?;
 
-        let _ = self
-            .tracker_statistics_importer
-            .import_torrent_statistics(torrent_id, &torrent_request.torrent.info_hash())
-            .await;
+        drop(
+            self.tracker_statistics_importer
+                .import_torrent_statistics(torrent_id, &torrent_request.torrent.info_hash())
+                .await,
+        );
 
         // We always whitelist the torrent on the tracker because even if the tracker mode is `public`
         // it could be changed to `private` later on.
@@ -131,7 +132,7 @@ impl Index {
             .await
         {
             // If the torrent can't be whitelisted somehow, remove the torrent from database
-            let _ = self.torrent_repository.delete(&torrent_id).await;
+            drop(self.torrent_repository.delete(&torrent_id).await);
             return Err(e);
         }
 
diff --git a/src/services/user.rs b/src/services/user.rs
@@ -126,7 +126,7 @@ impl RegistrationService {
 
         // If this is the first created account, give administrator rights
         if user_id == 1 {
-            let _ = self.user_repository.grant_admin_role(&user_id).await;
+            drop(self.user_repository.grant_admin_role(&user_id).await);
         }
 
         if settings.mail.email_verification_enabled && opt_email.is_some() {
@@ -141,7 +141,7 @@ impl RegistrationService {
                 .await;
 
             if mail_res.is_err() {
-                let _ = self.user_repository.delete(&user_id).await;
+                drop(self.user_repository.delete(&user_id).await);
                 return Err(ServiceError::FailedToSendVerificationEmail);
             }
         }
diff --git a/src/tracker/statistics_importer.rs b/src/tracker/statistics_importer.rs
@@ -69,13 +69,14 @@ impl StatisticsImporter {
     /// found.
     pub async fn import_torrent_statistics(&self, torrent_id: i64, info_hash: &str) -> Result<TorrentInfo, ServiceError> {
         if let Ok(torrent_info) = self.tracker_service.get_torrent_info(info_hash).await {
-            let _ = self
-                .database
-                .update_tracker_info(torrent_id, &self.tracker_url, torrent_info.seeders, torrent_info.leechers)
-                .await;
+            drop(
+                self.database
+                    .update_tracker_info(torrent_id, &self.tracker_url, torrent_info.seeders, torrent_info.leechers)
+                    .await,
+            );
             Ok(torrent_info)
         } else {
-            let _ = self.database.update_tracker_info(torrent_id, &self.tracker_url, 0, 0).await;
+            drop(self.database.update_tracker_info(torrent_id, &self.tracker_url, 0, 0).await);
             Err(ServiceError::TorrentNotFound)
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ pub async fn run(configuration: Configuration, api_version: &Version) -> Running`
`162`	`162`	`loop {`
`163`	`163`	`interval.tick().await;`
`164`	`164`	`if let Some(tracker) = weak_tracker_statistics_importer.upgrade() {`
`165`		`- let _ = tracker.import_all_torrents_statistics().await;`
	`165`	`+ drop(tracker.import_all_torrents_statistics().await);`
`166`	`166`	`} else {`
`167`	`167`	`break;`
`168`	`168`	`}`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ impl BytesCache {`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`// Remove the old entry so that a new entry will be added as last in the queue.`
`124`		`- let _ = self.bytes_table.shift_remove(&key);`
	`124`	`+ drop(self.bytes_table.shift_remove(&key));`
`125`	`125`
`126`	`126`	`let bytes_cache_entry = BytesCacheEntry::new(bytes);`
`127`	`127`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ impl Database for Mysql {`
`73`	`73`
`74`	`74`	`// rollback transaction on error`
`75`	`75`	`if let Err(e) = insert_user_auth_result {`
`76`		`- let _ = tx.rollback().await;`
	`76`	`+ drop(tx.rollback().await);`
`77`	`77`	`return Err(e);`
`78`	`78`	`}`
`79`	`79`
`@@ -100,11 +100,11 @@ impl Database for Mysql {`
`100`	`100`	`// commit or rollback transaction and return user_id on success`
`101`	`101`	`match insert_user_profile_result {`
`102`	`102`	`Ok(_) => {`
`103`		`- let _ = tx.commit().await;`
	`103`	`+ drop(tx.commit().await);`
`104`	`104`	`Ok(i64::overflowing_add_unsigned(0, user_id).0)`
`105`	`105`	`}`
`106`	`106`	`Err(e) => {`
`107`		`- let _ = tx.rollback().await;`
	`107`	`+ drop(tx.rollback().await);`
`108`	`108`	`Err(e)`
`109`	`109`	`}`
`110`	`110`	`}`
`@@ -497,7 +497,7 @@ impl Database for Mysql {`
`497`	`497`
`498`	`498`	`// rollback transaction on error`
`499`	`499`	`if let Err(e) = insert_torrent_files_result {`
`500`		`- let _ = tx.rollback().await;`
	`500`	`+ drop(tx.rollback().await);`
`501`	`501`	`return Err(e);`
`502`	`502`	`}`
`503`	`503`
`@@ -531,7 +531,7 @@ impl Database for Mysql {`
`531`	`531`
`532`	`532`	`// rollback transaction on error`
`533`	`533`	`if let Err(e) = insert_torrent_announce_urls_result {`
`534`		`- let _ = tx.rollback().await;`
	`534`	`+ drop(tx.rollback().await);`
`535`	`535`	`return Err(e);`
`536`	`536`	`}`
`537`	`537`
`@@ -558,11 +558,11 @@ impl Database for Mysql {`
`558`	`558`	`// commit or rollback transaction and return user_id on success`
`559`	`559`	`match insert_torrent_info_result {`
`560`	`560`	`Ok(_) => {`
`561`		`- let _ = tx.commit().await;`
	`561`	`+ drop(tx.commit().await);`
`562`	`562`	`Ok(torrent_id)`
`563`	`563`	`}`
`564`	`564`	`Err(e) => {`
`565`		`- let _ = tx.rollback().await;`
	`565`	`+ drop(tx.rollback().await);`
`566`	`566`	`Err(e)`
`567`	`567`	`}`
`568`	`568`	`}`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ impl Database for Sqlite {`
`74`	`74`
`75`	`75`	`// rollback transaction on error`
`76`	`76`	`if let Err(e) = insert_user_auth_result {`
`77`		`- let _ = tx.rollback().await;`
	`77`	`+ drop(tx.rollback().await);`
`78`	`78`	`return Err(e);`
`79`	`79`	`}`
`80`	`80`
`@@ -101,11 +101,11 @@ impl Database for Sqlite {`
`101`	`101`	`// commit or rollback transaction and return user_id on success`
`102`	`102`	`match insert_user_profile_result {`
`103`	`103`	`Ok(_) => {`
`104`		`- let _ = tx.commit().await;`
	`104`	`+ drop(tx.commit().await);`
`105`	`105`	`Ok(user_id)`
`106`	`106`	`}`
`107`	`107`	`Err(e) => {`
`108`		`- let _ = tx.rollback().await;`
	`108`	`+ drop(tx.rollback().await);`
`109`	`109`	`Err(e)`
`110`	`110`	`}`
`111`	`111`	`}`
`@@ -487,7 +487,7 @@ impl Database for Sqlite {`
`487`	`487`
`488`	`488`	`// rollback transaction on error`
`489`	`489`	`if let Err(e) = insert_torrent_files_result {`
`490`		`- let _ = tx.rollback().await;`
	`490`	`+ drop(tx.rollback().await);`
`491`	`491`	`return Err(e);`
`492`	`492`	`}`
`493`	`493`
`@@ -521,7 +521,7 @@ impl Database for Sqlite {`
`521`	`521`
`522`	`522`	`// rollback transaction on error`
`523`	`523`	`if let Err(e) = insert_torrent_announce_urls_result {`
`524`		`- let _ = tx.rollback().await;`
	`524`	`+ drop(tx.rollback().await);`
`525`	`525`	`return Err(e);`
`526`	`526`	`}`
`527`	`527`
`@@ -548,11 +548,11 @@ impl Database for Sqlite {`
`548`	`548`	`// commit or rollback transaction and return user_id on success`
`549`	`549`	`match insert_torrent_info_result {`
`550`	`550`	`Ok(_) => {`
`551`		`- let _ = tx.commit().await;`
	`551`	`+ drop(tx.commit().await);`
`552`	`552`	`Ok(torrent_id)`
`553`	`553`	`}`
`554`	`554`	`Err(e) => {`
`555`		`- let _ = tx.rollback().await;`
	`555`	`+ drop(tx.rollback().await);`
`556`	`556`	`Err(e)`
`557`	`557`	`}`
`558`	`558`	`}`
Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ impl InfoHash {`
`167`	`167`	`}`
`168`	`168`
`169`	`169`	`impl std::fmt::Display for InfoHash {`
`170`		`- fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {`
	`170`	`+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {`
`171`	`171`	`let mut chars = [0u8; 40];`
`172`	`172`	`binascii::bin2hex(&self.0, &mut chars).expect("failed to hexlify");`
`173`	`173`	`write!(f, "{}", std::str::from_utf8(&chars).unwrap())`
`@@ -271,7 +271,7 @@ struct InfoHashVisitor;`
`271`	`271`	`impl<'v> serde::de::Visitor<'v> for InfoHashVisitor {`
`272`	`272`	`type Value = InfoHash;`
`273`	`273`
`274`		`- fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {`
	`274`	`+ fn expecting(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {`
`275`	`275`	`write!(formatter, "a 40 character long hash")`
`276`	`276`	`}`
`277`	`277`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ impl RegistrationService {`
`126`	`126`
`127`	`127`	`// If this is the first created account, give administrator rights`
`128`	`128`	`if user_id == 1 {`
`129`		`- let _ = self.user_repository.grant_admin_role(&user_id).await;`
	`129`	`+ drop(self.user_repository.grant_admin_role(&user_id).await);`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`if settings.mail.email_verification_enabled && opt_email.is_some() {`
`@@ -141,7 +141,7 @@ impl RegistrationService {`
`141`	`141`	`.await;`
`142`	`142`
`143`	`143`	`if mail_res.is_err() {`
`144`		`- let _ = self.user_repository.delete(&user_id).await;`
	`144`	`+ drop(self.user_repository.delete(&user_id).await);`
`145`	`145`	`return Err(ServiceError::FailedToSendVerificationEmail);`
`146`	`146`	`}`
`147`	`147`	`}`