Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopPic Proforma Parser #113

Merged
merged 13 commits into from
Feb 14, 2024
Merged

TopPic Proforma Parser #113

merged 13 commits into from
Feb 14, 2024

Conversation

mikehollas123
Copy link
Contributor

Added a parser and tests for converting TopPic Proteoform strings into ProForma

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fc4cf39) 84.68% compared to head (854cac8) 85.32%.
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   84.68%   85.32%   +0.64%     
==========================================
  Files         102      103       +1     
  Lines        5542     5675     +133     
  Branches        0      878     +878     
==========================================
+ Hits         4693     4842     +149     
+ Misses        849      673     -176     
- Partials        0      160     +160     
Files Coverage Δ
...TopDownProteomics/ProForma/TopPicProformaParser.cs 99.20% <99.20%> (ø)

... and 34 files with indirect coverage changes

Copy link
Member

@rfellers rfellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some warnings about missing code coverage to check out also

* Changed Regx to be more inclusive
* fixed spelling issues
* TopPIC not TopPic
* Added info tags for TopPIC mod file parsing
* added new TopPicParserException class
Copy link
Member

@rfellers rfellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 4 code coverage warnings that need unit tests that trigger the exceptions. Also, some extra spaces that make anal-retentive me itchy.

rfellers
rfellers previously approved these changes Feb 7, 2024
Copy link
Member

@rfellers rfellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, love the tests

@rfellers rfellers merged commit 1e70f64 into master Feb 14, 2024
3 checks passed
@rfellers rfellers deleted the MikeH/TopicToProForma branch February 14, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants