-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TopPic Proforma Parser #113
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 84.68% 85.32% +0.64%
==========================================
Files 102 103 +1
Lines 5542 5675 +133
Branches 0 878 +878
==========================================
+ Hits 4693 4842 +149
+ Misses 849 673 -176
- Partials 0 160 +160
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some warnings about missing code coverage to check out also
* Changed Regx to be more inclusive * fixed spelling issues * TopPIC not TopPic
* Added info tags for TopPIC mod file parsing
* added new TopPicParserException class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 4 code coverage warnings that need unit tests that trigger the exceptions. Also, some extra spaces that make anal-retentive me itchy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, love the tests
Added a parser and tests for converting TopPic Proteoform strings into ProForma