fix few 500 errros

mr-tron · mr-tron · commit ef1f2c006b89 · 2024-02-03T23:39:11.000+03:00
diff --git a/api/openapi.json b/api/openapi.json
@@ -184,6 +184,7 @@
     "schema": {
      "default": 1000,
      "maximum": 1000,
+     "minimum": 1,
      "type": "integer"
     }
    },
@@ -256,6 +257,7 @@
     "required": false,
     "schema": {
      "default": 0,
+     "minimum": 0,
      "type": "integer"
     }
    },
@@ -5613,6 +5615,7 @@
       "schema": {
        "example": 100,
        "maximum": 1000,
+       "minimum": 1,
        "type": "integer"
       }
      },
@@ -5798,6 +5801,7 @@
       "schema": {
        "example": 100,
        "maximum": 1000,
+       "minimum": 1,
        "type": "integer"
       }
      },
@@ -5874,6 +5878,7 @@
       "schema": {
        "example": 100,
        "maximum": 1000,
+       "minimum": 1,
        "type": "integer"
       }
      },
@@ -5995,6 +6000,7 @@
       "schema": {
        "example": 100,
        "maximum": 1000,
+       "minimum": 1,
        "type": "integer"
       }
      },
@@ -6143,6 +6149,7 @@
        "default": 100,
        "example": 100,
        "maximum": 1000,
+       "minimum": 1,
        "type": "integer"
       }
      }
@@ -6386,6 +6393,7 @@
        "example": 100,
        "format": "int32",
        "maximum": 1000,
+       "minimum": 1,
        "type": "integer"
       }
      }
@@ -7072,6 +7080,7 @@
        "default": 100,
        "example": 100,
        "maximum": 1000,
+       "minimum": 1,
        "type": "integer"
       }
      }
@@ -7135,6 +7144,7 @@
        "default": 100,
        "example": 100,
        "maximum": 1000,
+       "minimum": 1,
        "type": "integer"
       }
      }
@@ -7280,6 +7290,7 @@
        "example": 15,
        "format": "int32",
        "maximum": 1000,
+       "minimum": 1,
        "type": "integer"
       }
      },
@@ -7290,6 +7301,7 @@
        "default": 0,
        "example": 10,
        "format": "int32",
+       "minimum": 0,
        "type": "integer"
       }
      }
@@ -8374,6 +8386,7 @@
        "example": 15,
        "format": "int32",
        "maximum": 1000,
+       "minimum": 1,
        "type": "integer"
       }
      },
@@ -8384,6 +8397,7 @@
        "default": 0,
        "example": 10,
        "format": "int32",
+       "minimum": 0,
        "type": "integer"
       }
      }
@@ -8530,6 +8544,7 @@
       "schema": {
        "example": 100,
        "maximum": 1000,
+       "minimum": 1,
        "type": "integer"
       }
      },
diff --git a/api/openapi.yml b/api/openapi.yml
@@ -241,6 +241,7 @@ paths:
             maximum: 1000
             default: 100
             example: 100
+            minimum: 1
       responses:
         '200':
           description: blockchain account transactions
@@ -597,6 +598,7 @@ paths:
             type: integer
             example: 100
             maximum: 1000
+            minimum: 1
         - name: start_date
           in: query
           required: false
@@ -645,6 +647,7 @@ paths:
             type: integer
             example: 100
             maximum: 1000
+            minimum: 1
         - name: start_date
           in: query
           required: false
@@ -719,6 +722,7 @@ paths:
             type: integer
             example: 100
             maximum: 1000
+            minimum: 1
         - name: start_date
           in: query
           required: false
@@ -774,6 +778,7 @@ paths:
             type: integer
             example: 100
             maximum: 1000
+            minimum: 1
         - name: start_date
           in: query
           required: false
@@ -838,6 +843,7 @@ paths:
             maximum: 1000
             default: 100
             example: 100
+            minimum: 1
       responses:
         '200':
           description: account's traces
@@ -1064,13 +1070,15 @@ paths:
             maximum: 1000
             default: 100
             example: 15
+            minimum: 1
         - name: offset
           in: query
           schema:
             type: integer
             format: int32
             default: 0
             example: 10
+            minimum: 0
       responses:
         '200':
           description: nft collections
@@ -1174,6 +1182,7 @@ paths:
             type: integer
             example: 100
             maximum: 1000
+            minimum: 1
         - name: start_date
           in: query
           required: false
@@ -1278,6 +1287,7 @@ paths:
                 example: 100
                 default: 100
                 maximum: 1000
+                minimum: 1
         responses:
             '200':
               description: account inscriptions history
@@ -1318,6 +1328,7 @@ paths:
                 example: 100
                 default: 100
                 maximum: 1000
+                minimum: 1
         responses:
             '200':
               description: account inscriptions history
@@ -1410,13 +1421,15 @@ paths:
             maximum: 1000
             default: 100
             example: 15
+            minimum: 1
         - name: offset
           in: query
           schema:
             type: integer
             format: int32
             default: 0
             example: 10
+            minimum: 0
       responses:
         '200':
           description: a list of jettons
@@ -2569,13 +2582,15 @@ components:
         type: integer
         default: 1000
         maximum: 1000
+        minimum: 1
     offsetQuery:
       in: query
       name: offset
       required: false
       schema:
         type: integer
         default: 0
+        minimum: 0
     domainFilterQuery:
       in: query
       name: tld
diff --git a/pkg/api/account_handlers.go b/pkg/api/account_handlers.go
@@ -285,6 +285,9 @@ func (h *Handler) GetAccountPublicKey(ctx context.Context, params oas.GetAccount
 	}
 	if err != nil {
 		state, err := h.storage.GetRawAccount(ctx, account.ID)
+		if errors.Is(err, core.ErrEntityNotFound) {
+			return nil, toError(http.StatusNotFound, err)
+		}
 		if err != nil {
 			return nil, toError(http.StatusInternalServerError, err)
 		}
diff --git a/pkg/oas/oas_parameters_gen.go b/pkg/oas/oas_parameters_gen.go

Original file line number	Diff line number	Diff line change
`@@ -184,6 +184,7 @@`
`184`	`184`	`"schema": {`
`185`	`185`	`"default": 1000,`
`186`	`186`	`"maximum": 1000,`
	`187`	`+ "minimum": 1,`
`187`	`188`	`"type": "integer"`
`188`	`189`	`}`
`189`	`190`	`},`
`@@ -256,6 +257,7 @@`
`256`	`257`	`"required": false,`
`257`	`258`	`"schema": {`
`258`	`259`	`"default": 0,`
	`260`	`+ "minimum": 0,`
`259`	`261`	`"type": "integer"`
`260`	`262`	`}`
`261`	`263`	`},`
`@@ -5613,6 +5615,7 @@`
`5613`	`5615`	`"schema": {`
`5614`	`5616`	`"example": 100,`
`5615`	`5617`	`"maximum": 1000,`
	`5618`	`+ "minimum": 1,`
`5616`	`5619`	`"type": "integer"`
`5617`	`5620`	`}`
`5618`	`5621`	`},`
`@@ -5798,6 +5801,7 @@`
`5798`	`5801`	`"schema": {`
`5799`	`5802`	`"example": 100,`
`5800`	`5803`	`"maximum": 1000,`
	`5804`	`+ "minimum": 1,`
`5801`	`5805`	`"type": "integer"`
`5802`	`5806`	`}`
`5803`	`5807`	`},`
`@@ -5874,6 +5878,7 @@`
`5874`	`5878`	`"schema": {`
`5875`	`5879`	`"example": 100,`
`5876`	`5880`	`"maximum": 1000,`
	`5881`	`+ "minimum": 1,`
`5877`	`5882`	`"type": "integer"`
`5878`	`5883`	`}`
`5879`	`5884`	`},`
`@@ -5995,6 +6000,7 @@`
`5995`	`6000`	`"schema": {`
`5996`	`6001`	`"example": 100,`
`5997`	`6002`	`"maximum": 1000,`
	`6003`	`+ "minimum": 1,`
`5998`	`6004`	`"type": "integer"`
`5999`	`6005`	`}`
`6000`	`6006`	`},`
`@@ -6143,6 +6149,7 @@`
`6143`	`6149`	`"default": 100,`
`6144`	`6150`	`"example": 100,`
`6145`	`6151`	`"maximum": 1000,`
	`6152`	`+ "minimum": 1,`
`6146`	`6153`	`"type": "integer"`
`6147`	`6154`	`}`
`6148`	`6155`	`}`
`@@ -6386,6 +6393,7 @@`
`6386`	`6393`	`"example": 100,`
`6387`	`6394`	`"format": "int32",`
`6388`	`6395`	`"maximum": 1000,`
	`6396`	`+ "minimum": 1,`
`6389`	`6397`	`"type": "integer"`
`6390`	`6398`	`}`
`6391`	`6399`	`}`
`@@ -7072,6 +7080,7 @@`
`7072`	`7080`	`"default": 100,`
`7073`	`7081`	`"example": 100,`
`7074`	`7082`	`"maximum": 1000,`
	`7083`	`+ "minimum": 1,`
`7075`	`7084`	`"type": "integer"`
`7076`	`7085`	`}`
`7077`	`7086`	`}`
`@@ -7135,6 +7144,7 @@`
`7135`	`7144`	`"default": 100,`
`7136`	`7145`	`"example": 100,`
`7137`	`7146`	`"maximum": 1000,`
	`7147`	`+ "minimum": 1,`
`7138`	`7148`	`"type": "integer"`
`7139`	`7149`	`}`
`7140`	`7150`	`}`
`@@ -7280,6 +7290,7 @@`
`7280`	`7290`	`"example": 15,`
`7281`	`7291`	`"format": "int32",`
`7282`	`7292`	`"maximum": 1000,`
	`7293`	`+ "minimum": 1,`
`7283`	`7294`	`"type": "integer"`
`7284`	`7295`	`}`
`7285`	`7296`	`},`
`@@ -7290,6 +7301,7 @@`
`7290`	`7301`	`"default": 0,`
`7291`	`7302`	`"example": 10,`
`7292`	`7303`	`"format": "int32",`
	`7304`	`+ "minimum": 0,`
`7293`	`7305`	`"type": "integer"`
`7294`	`7306`	`}`
`7295`	`7307`	`}`
`@@ -8374,6 +8386,7 @@`
`8374`	`8386`	`"example": 15,`
`8375`	`8387`	`"format": "int32",`
`8376`	`8388`	`"maximum": 1000,`
	`8389`	`+ "minimum": 1,`
`8377`	`8390`	`"type": "integer"`
`8378`	`8391`	`}`
`8379`	`8392`	`},`
`@@ -8384,6 +8397,7 @@`
`8384`	`8397`	`"default": 0,`
`8385`	`8398`	`"example": 10,`
`8386`	`8399`	`"format": "int32",`
	`8400`	`+ "minimum": 0,`
`8387`	`8401`	`"type": "integer"`
`8388`	`8402`	`}`
`8389`	`8403`	`}`
`@@ -8530,6 +8544,7 @@`
`8530`	`8544`	`"schema": {`
`8531`	`8545`	`"example": 100,`
`8532`	`8546`	`"maximum": 1000,`
	`8547`	`+ "minimum": 1,`
`8533`	`8548`	`"type": "integer"`
`8534`	`8549`	`}`
`8535`	`8550`	`},`
Original file line number	Diff line number	Diff line change
`@@ -285,6 +285,9 @@ func (h *Handler) GetAccountPublicKey(ctx context.Context, params oas.GetAccount`
`285`	`285`	`}`
`286`	`286`	`if err != nil {`
`287`	`287`	`state, err := h.storage.GetRawAccount(ctx, account.ID)`
	`288`	`+ if errors.Is(err, core.ErrEntityNotFound) {`
	`289`	`+ return nil, toError(http.StatusNotFound, err)`
	`290`	`+ }`
`288`	`291`	`if err != nil {`
`289`	`292`	`return nil, toError(http.StatusInternalServerError, err)`
`290`	`293`	`}`