Merge pull request #559 from tonkeeper/order-fix-for-get-method

Order fix for get method

Author: mr-tron

api/openapi.json

@@ -7268,6 +7268,16 @@
        },
        "type": "array"
       }
+     },
+     {
+      "in": "query",
+      "name": "fix_order",
+      "required": false,
+      "schema": {
+       "default": true,
+       "description": "A temporary fix to switch to a scheme with direct ordering of arguments. \nIf equal to false, then the method takes arguments in direct order,\ne.g. for get_nft_content(int index, cell individual_content) we pass a list of arguments [index, individual_content].\nIf equal to true, then the method takes arguments in reverse order, e.g. [individual_content, index].",
+       "type": "boolean"
+      }
      }
     ],
     "responses": {

api/openapi.yml

@@ -396,6 +396,17 @@ paths:
             items:
               type: string
             example: [ "0:9a33970f617bcd71acf2cd28357c067aa31859c02820d8f01d74c88063a8f4d8" ]
+        - name: fix_order
+          in: query
+          required: false
+          schema:
+            type: boolean
+            description: |-
+              A temporary fix to switch to a scheme with direct ordering of arguments. 
+              If equal to false, then the method takes arguments in direct order,
+              e.g. for get_nft_content(int index, cell individual_content) we pass a list of arguments [index, individual_content].
+              If equal to true, then the method takes arguments in reverse order, e.g. [individual_content, index].
+            default: true
       responses:
         '200':
           description: method execution result

pkg/api/account_handlers.go

@@ -8,6 +8,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"golang.org/x/exp/slices"
 	"net/http"
 	"sort"
 	"strings"
@@ -200,6 +201,10 @@ func (h *Handler) ExecGetMethodForBlockchainAccount(ctx context.Context, params
 		}
 		return nil, toError(http.StatusInternalServerError, err)
 	}
+	// TODO: remove parameter after user migration
+	if params.FixOrder.IsSet() && params.FixOrder.Value == true && len(params.Args) > 1 {
+		slices.Reverse(params.Args)
+	}
 	key, err := getMethodCacheKey(account.ID, params.MethodName, contract.LastTransactionLt, params.Args)
 	if err != nil {
 		return nil, toError(http.StatusInternalServerError, err)
@@ -208,12 +213,12 @@ func (h *Handler) ExecGetMethodForBlockchainAccount(ctx context.Context, params
 		return result, nil
 	}
 	stack := make([]tlb.VmStackValue, 0, len(params.Args))
-	for _, p := range params.Args {
-		r, err := stringToTVMStackRecord(p)
+	for i := len(params.Args) - 1; i >= 0; i-- {
+		r, err := stringToTVMStackRecord(params.Args[i])
 		if err != nil {
-			return nil, toError(http.StatusBadRequest, fmt.Errorf("can't parse arg '%v' as any TVMStackValue", p))
+			return nil, toError(http.StatusBadRequest, fmt.Errorf("can't parse arg '%v' as any TVMStackValue", params.Args[i]))
 		}
-		stack = append(stack, r)
+		stack = append(stack, r) // we need to put the arguments on the stack in reverse order
 	}
 	// RunSmcMethodByID fetches the contract from the storage on its own,
 	// and it can happen that the contract has been changed and has another lt,