fix: set span end time when it exits

Setting end time when a span is closed makes it impossible for child
spans to live longer than their parents if we want to keep the
relationship in `tracing` itself.

Author: mladedav

src/layer.rs

@@ -970,13 +970,19 @@ where
     }
 
     fn on_exit(&self, id: &span::Id, ctx: Context<'_, S>) {
+        let span = ctx.span(id).expect("Span not found, this is a bug");
+        let mut extensions = span.extensions_mut();
+
+        extensions
+            .get_mut::<OtelData>()
+            .expect("Missing otel data span extensions")
+            .builder
+            .end_time = Some(crate::time::now());
+
         if !self.tracked_inactivity {
             return;
         }
 
-        let span = ctx.span(id).expect("Span not found, this is a bug");
-        let mut extensions = span.extensions_mut();
-
         if let Some(timings) = extensions.get_mut::<Timings>() {
             let now = Instant::now();
             timings.busy += (now - timings.last).as_nanos() as i64;
@@ -1165,9 +1171,7 @@ where
             }
 
             // Assign end time, build and start span, drop span to export
-            builder
-                .with_end_time(crate::time::now())
-                .start_with_context(&self.tracer, &parent_cx);
+            builder.start_with_context(&self.tracer, &parent_cx);
         }
     }