Skip to content

Commit d9f9132

Browse files
authored
Merge pull request #1113 from tier4/fix/raw_vehicle_cmd_converter
fix(raw_vehicle_cmd_converter): fix parameter files to parse path to csv files
2 parents 085dfca + d747718 commit d9f9132

File tree

4 files changed

+9
-18
lines changed

4 files changed

+9
-18
lines changed

launch/tier4_vehicle_launch/launch/vehicle.launch.xml

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
<arg name="vehicle_id" default="$(env VEHICLE_ID default)" description="vehicle specific ID"/>
77
<arg name="initial_engage_state" default="false" description="/vehicle/engage state after starting Autoware"/>
88
<arg name="config_dir" default="$(find-pkg-share $(var sensor_model)_description)/config" description="path to dir where sensors_calibration.yaml, etc. are located"/>
9+
<arg name="raw_vehicle_cmd_converter_param_path" default="$(find-pkg-share raw_vehicle_cmd_converter)/config/raw_vehicle_cmd_converter.param.yaml"/>
910

1011
<let name="vehicle_launch_pkg" value="$(find-pkg-share $(var vehicle_model)_launch)"/>
1112

@@ -21,6 +22,7 @@
2122
<group if="$(var launch_vehicle_interface)">
2223
<include file="$(var vehicle_launch_pkg)/launch/vehicle_interface.launch.xml">
2324
<arg name="vehicle_id" value="$(var vehicle_id)"/>
25+
<arg name="raw_vehicle_cmd_converter_param_path" value="$(var raw_vehicle_cmd_converter_param_path)"/>
2426
<arg name="initial_engage_state" value="$(var initial_engage_state)"/>
2527
</include>
2628
</group>

vehicle/raw_vehicle_cmd_converter/config/raw_vehicle_cmd_converter.param.yaml

-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
/**:
22
ros__parameters:
3-
csv_path_accel_map: "$(find-pkg-share raw_vehicle_cmd_converter)/data/default/accel_map.csv"
4-
csv_path_brake_map: "$(find-pkg-share raw_vehicle_cmd_converter)/data/default/brake_map.csv"
5-
csv_path_steer_map: "$(find-pkg-share raw_vehicle_cmd_converter)/data/default/steer_map.csv"
63
convert_accel_cmd: true
74
convert_brake_cmd: true
85
convert_steer_cmd: true

vehicle/raw_vehicle_cmd_converter/launch/raw_vehicle_converter.launch.xml

+7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
<?xml version="1.0"?>
22
<launch>
3+
<arg name="csv_path_accel_map" default="$(find-pkg-share raw_vehicle_cmd_converter)/data/default/accel_map.csv"/>
4+
<arg name="csv_path_brake_map" default="$(find-pkg-share raw_vehicle_cmd_converter)/data/default/brake_map.csv"/>
5+
<arg name="csv_path_steer_map" default="$(find-pkg-share raw_vehicle_cmd_converter)/data/default/steer_map.csv"/>
6+
37
<arg name="input_control_cmd" default="/control/command/control_cmd"/>
48
<arg name="input_odometry" default="/localization/kinematic_state"/>
59
<arg name="input_steering" default="/vehicle/status/steering_status"/>
@@ -9,6 +13,9 @@
913

1014
<node pkg="raw_vehicle_cmd_converter" exec="raw_vehicle_cmd_converter_node" name="raw_vehicle_cmd_converter" output="screen">
1115
<param from="$(var config_file)" allow_substs="true"/>
16+
<param name="csv_path_accel_map" value="$(var csv_path_accel_map)"/>
17+
<param name="csv_path_brake_map" value="$(var csv_path_brake_map)"/>
18+
<param name="csv_path_steer_map" value="$(var csv_path_steer_map)"/>
1219
<remap from="~/input/control_cmd" to="$(var input_control_cmd)"/>
1320
<remap from="~/input/odometry" to="$(var input_odometry)"/>
1421
<remap from="~/input/steering" to="$(var input_steering)"/>

vehicle/raw_vehicle_cmd_converter/schema/raw_vehicle_cmd_converter.schema.json

-15
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,6 @@
66
"raw_vehicle_cmd_converter": {
77
"type": "object",
88
"properties": {
9-
"csv_path_accel_map": {
10-
"type": "string",
11-
"description": "path for acceleration map csv file",
12-
"default": "$(find-pkg-share raw_vehicle_cmd_converter)/data/default/accel_map.csv"
13-
},
14-
"csv_path_brake_map": {
15-
"type": "string",
16-
"description": "path for brake map csv file",
17-
"default": "$(find-pkg-share raw_vehicle_cmd_converter)/data/default/brake_map.csv"
18-
},
19-
"csv_path_steer_map": {
20-
"type": "string",
21-
"description": "path for steer map csv file",
22-
"default": "$(find-pkg-share raw_vehicle_cmd_converter)/data/default/steer_map.csv"
23-
},
249
"convert_accel_cmd": {
2510
"type": "boolean",
2611
"description": "use accel or not",

0 commit comments

Comments
 (0)