feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again (autowarefoundation#6468) (#1156)

feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again (autowarefoundation#6468)

* feat(behavior_velocity_traffic_light): ensure stopping if a signal, once received, is not received again."



* add comments for clarity



* fix comments for clarity



---------

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Author: TomohitoAndo

planning/behavior_velocity_planner/src/node.cpp

@@ -327,6 +327,8 @@ void BehaviorVelocityPlannerNode::onTrafficSignals(
 {
   std::lock_guard<std::mutex> lock(mutex_);
 
+  planner_data_.has_received_signal_ = true;
+
   for (const auto & signal : msg->signals) {
     TrafficSignalStamped traffic_signal;
     traffic_signal.stamp = msg->stamp;

planning/behavior_velocity_planner_common/include/behavior_velocity_planner_common/planner_data.hpp

@@ -82,6 +82,9 @@ struct PlannerData
   std::map<int, TrafficSignalTimeToRedStamped> traffic_light_time_to_red_id_map;
   tier4_v2x_msgs::msg::VirtualTrafficLightStateArray::ConstSharedPtr virtual_traffic_light_states;
 
+  // this value becomes true once the signal message is received
+  bool has_received_signal_ = false;
+
   // velocity smoother
   std::shared_ptr<motion_velocity_smoother::SmootherBase> velocity_smoother_;
   // route handler

planning/behavior_velocity_traffic_light_module/src/scene.cpp

@@ -303,11 +303,20 @@ bool TrafficLightModule::isStopSignal()
 {
   updateTrafficSignal();
 
-  // If it never receives traffic signal, it will PASS.
-  if (!traffic_signal_stamp_) {
+  // Pass through if no traffic signal information has been received yet
+  // This is to prevent stopping on the planning simulator
+  if (!planner_data_->has_received_signal_) {
     return false;
   }
 
+  // Stop if there is no upcoming traffic signal information
+  // This is to safely stop in cases such that traffic light recognition is not working properly or
+  // the map is incorrect
+  if (!traffic_signal_stamp_) {
+    return true;
+  }
+
+  // Stop if the traffic signal information has timed out
   if (isTrafficSignalTimedOut()) {
     return true;
   }