fix(goal_planner): fix time_keeper race (autowarefoundation#8780) (#1555)

shmpwk · soblin · web-flow · commit be5ab5558d95 · 2024-09-25T19:54:26.000+09:00
Signed-off-by: Mamoru Sobue &lt;mamoru.sobue@tier4.jp&gt;
Co-authored-by: Mamoru Sobue &lt;hilo.soblin@gmail.com&gt;
diff --git a/planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/src/goal_planner_module.cpp b/planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/src/goal_planner_module.cpp
@@ -1259,8 +1259,6 @@ bool GoalPlannerModule::hasNotDecidedPath(
   const std::shared_ptr<SafetyCheckParams> & safety_check_params,
   const std::shared_ptr<GoalSearcherBase> goal_searcher) const
 {
-  universe_utils::ScopedTimeTrack st(__func__, *time_keeper_);
-
   return checkDecidingPathStatus(
            planner_data, occupancy_grid_map, parameters, ego_predicted_path_params,
            objects_filtering_params, safety_check_params, goal_searcher)
@@ -2371,8 +2369,6 @@ std::pair<bool, bool> GoalPlannerModule::isSafePath(
   const std::shared_ptr<ObjectsFilteringParams> & objects_filtering_params,
   const std::shared_ptr<SafetyCheckParams> & safety_check_params) const
 {
-  universe_utils::ScopedTimeTrack st(__func__, *time_keeper_);
-
   if (!thread_safe_data_.get_pull_over_path()) {
     return {false, false};
   }

Original file line number	Diff line number	Diff line change
`@@ -1259,8 +1259,6 @@ bool GoalPlannerModule::hasNotDecidedPath(`
`1259`	`1259`	`const std::shared_ptr<SafetyCheckParams> & safety_check_params,`
`1260`	`1260`	`const std::shared_ptr<GoalSearcherBase> goal_searcher) const`
`1261`	`1261`	`{`
`1262`		`- universe_utils::ScopedTimeTrack st(__func__, *time_keeper_);`
`1263`		`-`
`1264`	`1262`	`return checkDecidingPathStatus(`
`1265`	`1263`	`planner_data, occupancy_grid_map, parameters, ego_predicted_path_params,`
`1266`	`1264`	`objects_filtering_params, safety_check_params, goal_searcher)`
`@@ -2371,8 +2369,6 @@ std::pair<bool, bool> GoalPlannerModule::isSafePath(`
`2371`	`2369`	`const std::shared_ptr<ObjectsFilteringParams> & objects_filtering_params,`
`2372`	`2370`	`const std::shared_ptr<SafetyCheckParams> & safety_check_params) const`
`2373`	`2371`	`{`
`2374`		`- universe_utils::ScopedTimeTrack st(__func__, *time_keeper_);`
`2375`		`-`
`2376`	`2372`	`if (!thread_safe_data_.get_pull_over_path()) {`
`2377`	`2373`	`return {false, false};`
`2378`	`2374`	`}`