chore(duplicate_node_checker): print duplication name (autowarefoundation#6488)

soblin · saka1-s · commit aee6c8d79978 · 2024-03-04T18:07:38.000+09:00
Signed-off-by: Mamoru Sobue &lt;mamoru.sobue@tier4.jp&gt;
diff --git a/system/duplicated_node_checker/config/duplicated_node_checker.param.yaml b/system/duplicated_node_checker/config/duplicated_node_checker.param.yaml
@@ -1,4 +1,4 @@
 /**:
   ros__parameters:
     update_rate: 10.0
-    add_duplicated_node_names_to_msg: false # if true, duplicated node names are added to msg
+    add_duplicated_node_names_to_msg: true # if true, duplicated node names are added to msg
diff --git a/system/duplicated_node_checker/package.xml b/system/duplicated_node_checker/package.xml
@@ -6,6 +6,7 @@
   <description>A package to find out nodes with common names</description>
   <maintainer email="shumpei.wakabayashi@tier4.jp">Shumpei Wakabayashi</maintainer>
   <maintainer email="uken.ryu@tier4.jp">yliuhb</maintainer>
+  <maintainer email="mamoru.sobue@tier4.jp">Mamoru Sobue</maintainer>
   <license>Apache 2.0</license>
 
   <buildtool_depend>ament_cmake</buildtool_depend>
diff --git a/system/duplicated_node_checker/src/duplicated_node_checker_core.cpp b/system/duplicated_node_checker/src/duplicated_node_checker_core.cpp
@@ -69,7 +69,7 @@ void DuplicatedNodeChecker::produceDiagnostics(diagnostic_updater::DiagnosticSta
     if (add_duplicated_node_names_to_msg_) {
       std::set<std::string> unique_identical_names(identical_names.begin(), identical_names.end());
       for (const auto & name : unique_identical_names) {
-        msg += " " + name;
+        msg += "[" + name + "], ";
       }
     }
     for (auto name : identical_names) {

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ void DuplicatedNodeChecker::produceDiagnostics(diagnostic_updater::DiagnosticSta`
`69`	`69`	`if (add_duplicated_node_names_to_msg_) {`
`70`	`70`	`std::set<std::string> unique_identical_names(identical_names.begin(), identical_names.end());`
`71`	`71`	`for (const auto & name : unique_identical_names) {`
`72`		`- msg += " " + name;`
	`72`	`+ msg += "[" + name + "], ";`
`73`	`73`	`}`
`74`	`74`	`}`
`75`	`75`	`for (auto name : identical_names) {`