Skip to content

Commit 3fe6fe9

Browse files
add update_param
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
1 parent dad52f7 commit 3fe6fe9

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

control/autoware_pid_longitudinal_controller/include/autoware/pid_longitudinal_controller/lowpass_filter.hpp

+2
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ class LowpassFilter1d
6161
m_x = ret;
6262
return ret;
6363
}
64+
65+
void setGain(const double g) { m_gain = g; }
6466
};
6567
} // namespace autoware::motion::control::pid_longitudinal_controller
6668
#endif // AUTOWARE__PID_LONGITUDINAL_CONTROLLER__LOWPASS_FILTER_HPP_

control/autoware_pid_longitudinal_controller/src/pid_longitudinal_controller.cpp

+8-1
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,10 @@ rcl_interfaces::msg::SetParametersResult PidLongitudinalController::paramCallbac
296296
update_param("kd", kd);
297297
m_pid_vel.setGains(kp, ki, kd);
298298

299+
double lpf_vel_error_gain{node_parameters_->get_parameter("lpf_vel_error_gain").as_double()};
300+
update_param("lpf_vel_error_gain", lpf_vel_error_gain);
301+
m_lpf_vel_error->setGain(lpf_vel_error_gain);
302+
299303
double max_pid{node_parameters_->get_parameter("max_out").as_double()};
300304
double min_pid{node_parameters_->get_parameter("min_out").as_double()};
301305
double max_p{node_parameters_->get_parameter("max_p_effort").as_double()};
@@ -370,8 +374,11 @@ rcl_interfaces::msg::SetParametersResult PidLongitudinalController::paramCallbac
370374
update_param("emergency_jerk", p.jerk);
371375
}
372376

373-
// acceleration limit
377+
// acceleration feedback
374378
update_param("acc_feedback_gain", m_acc_feedback_gain);
379+
double lpf_acc_error_gain{node_parameters_->get_parameter("lpf_acc_error_gain").as_double()};
380+
update_param("lpf_acc_error_gain", lpf_acc_error_gain);
381+
m_lpf_acc_error->setGain(lpf_acc_error_gain);
375382

376383
// acceleration limit
377384
update_param("min_acc", m_min_acc);

0 commit comments

Comments
 (0)