merge pr #526: allow fill = NULL in shade_*() functions

Author: simonpcouch

NEWS.md

@@ -6,6 +6,8 @@
 * Addresses ggplot2 warnings when shading p-values for test statistics
   that are outside of the range of the generated distribution (#528).
 
+* Fixed bug in `shade_p_value()` and `shade_confidence_interval()` where `fill = NULL` was ignored when it was documented as preventing any shading (#525).
+
 # infer v1.0.6
 
 * Updated infrastructure for errors, warnings, and messages (#513). Most of these changes will not be visible to users, though:

R/shade_confidence_interval.R

@@ -133,7 +133,7 @@ shade_confidence_interval <- function(endpoints, color = "mediumaquamarine",
     fn = "shade_confidence_interval",
     endpoints = if (is.null(endpoints)) {NA} else {endpoints},
     color = color,
-    fill = fill,
+    fill = list(fill),
     dots = list(...)
   )
 }

R/shade_p_value.R

@@ -123,7 +123,7 @@ shade_p_value <- function(obs_stat, direction,
     obs_stat = if (is.null(obs_stat)) {NA} else {obs_stat},
     direction = if (is.null(direction)) {NA} else {direction},
     color = color,
-    fill = fill,
+    fill = list(fill),
     dots = list(...)
   )
 }

R/visualize.R

@@ -689,6 +689,7 @@ ggplot_add.infer_layer <- function(object, plot, object_name) {
   shade_fn <- attr(object, "fn")
   shade_args <- attributes(object)[!names(attributes(object)) %in%
                                      c("class", "fn")]
+  shade_args["fill"] <- shade_args[["fill"]]
 
   # if a patchwork object, use a custom `infer_layer` `+.gg` method.
   # otherwise, convert the `infer_layer` back to a list and call `+` again.