Solr 9.7 → 9.8 for integration tests

Author: thomascorthals

.github/workflows/run-tests.yml

@@ -51,26 +51,26 @@ jobs:
                 ref: branch_8_11
                 path: lucene-solr
 
-            - name: Checkout solr 9.7
+            - name: Checkout solr 9.8
               if: matrix.solr == 9
               uses: actions/checkout@v4
               with:
                 repository: apache/solr
-                ref: branch_9_7
+                ref: branch_9_8
                 path: lucene-solr
 
             - name: Start Solr ${{ matrix.solr }} in ${{ matrix.mode }} mode
               run: |
                 chmod -R a+w lucene-solr
                 cd lucene-solr
-                patch -p1 < ../tests/Integration/Fixtures/solrconf.patch
-                patch -p1 < ../tests/Integration/Fixtures/schema${{ matrix.solr }}.patch
+                patch -p1 < ../tests/Integration/Fixtures/conf/solrconf${{ matrix.solr }}.patch
+                patch -p1 < ../tests/Integration/Fixtures/conf/schema${{ matrix.solr }}.patch
                 cd solr/server/solr/configsets/sample_techproducts_configs/conf
                 zip -r techproducts.zip *
                 cd -
                 mv solr/server/solr/configsets/sample_techproducts_configs/conf/techproducts.zip ../tests/Integration/Fixtures/
                 cd ../tests/Integration/Fixtures/docker/solr${{ matrix.solr }}_${{ matrix.mode }}
-                docker compose up -d
+                docker compose up
 
             - name: Install dependencies
               run: |

tests/Integration/AbstractTechproductsTestCase.php

@@ -172,6 +172,23 @@ public static function setUpBeforeClass(): void
                 self::$client->update($update);
             }
 
+            // UTF8TEST was removed for Solr 9.8 in SOLR-17556
+            if (9 <= self::$solrVersion) {
+                $update = self::$client->createUpdate();
+
+                $utf8test = $update->createDocument();
+                $utf8test->setField('id', 'UTF8TEST');
+                $utf8test->setField('manu', 'Apache Software Foundation');
+                $utf8test->setField('cat', 'software');
+                $utf8test->setField('cat', 'search');
+                $utf8test->setField('features', 'êâîôû');
+                $utf8test->setField('price', 0.0);
+                $utf8test->setField('inStock', true);
+
+                $update->addDocument($utf8test);
+                self::$client->update($update);
+            }
+
             $update = self::$client->createUpdate();
             $update->addCommit(false, true);
             self::$client->update($update);
@@ -4953,6 +4970,13 @@ public function testManagedStopwords()
      */
     public function testManagedStopwordsCreation(string $name, string $term)
     {
+        // this test triggers an error for Solr 9.8 in SolrCloud mode
+        if (9 === self::$solrVersion && $this instanceof AbstractCloudTestCase) {
+            $this->expectNotToPerformAssertions();
+
+            return;
+        }
+
         // don't use invalid filename characters in list name on Windows to avoid running into SOLR-15895
         if (self::$isSolrOnWindows) {
             $name = str_replace([':', '/', '?'], '', $name);
@@ -5118,6 +5142,13 @@ public function testManagedSynonyms()
      */
     public function testManagedSynonymsCreation(string $name, string $term)
     {
+        // this test triggers an error for Solr 9.8 in SolrCloud mode
+        if (9 === self::$solrVersion && $this instanceof AbstractCloudTestCase) {
+            $this->expectNotToPerformAssertions();
+
+            return;
+        }
+
         // don't use invalid filename characters in map name on Windows to avoid running into SOLR-15895
         if (self::$isSolrOnWindows) {
             $name = str_replace([':', '/', '?'], '', $name);

tests/Integration/Fixtures/schema7.patch tests/Integration/Fixtures/conf/schema7.patch

@@ -1,20 +1,20 @@
 diff --git a/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml b/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
-index 06ac9b3d2e6..087287d2339 100644
+index 1570be4870b..3eab43beead 100644
 --- a/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
 +++ b/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
 @@ -86,6 +86,8 @@
    <lib dir="${solr.install.dir:../../../..}/contrib/velocity/lib" regex=".*\.jar" />
    <lib dir="${solr.install.dir:../../../..}/dist/" regex="solr-velocity-\d.*\.jar" />
- 
+
 +  <lib dir="${solr.install.dir:../../../..}/dist"/>
 +
    <!-- an exact 'path' can be used instead of a 'dir' to specify a
         specific jar file.  This will cause a serious error to be logged
         if it can't be loaded.
-@@ -1008,6 +1010,39 @@
- 
+@@ -991,6 +993,39 @@
+
       -->
- 
+
 +  <!-- A request handler for MLT queries.
 +    -->
 +  <requestHandler name="/mlt" class="solr.MoreLikeThisHandler" />
@@ -49,5 +49,5 @@ index 06ac9b3d2e6..087287d2339 100644
 +  </requestHandler>
 +
     <!-- Spell Check
- 
+
          The spell check component can return a list of alternative spelling

tests/Integration/Fixtures/schema8.patch tests/Integration/Fixtures/conf/schema8.patch

@@ -0,0 +1,53 @@
+diff --git a/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml b/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
+index 360e6dbf8ee..949a0b1c5f8 100644
+--- a/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
++++ b/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
+@@ -83,6 +83,8 @@
+   <lib dir="${solr.install.dir:../../../..}/contrib/velocity/lib" regex=".*\.jar" />
+   <lib dir="${solr.install.dir:../../../..}/dist/" regex="solr-velocity-\d.*\.jar" />
+
++  <lib dir="${solr.install.dir:../../../..}/dist"/>
++
+   <!-- an exact 'path' can be used instead of a 'dir' to specify a
+        specific jar file.  This will cause a serious error to be logged
+        if it can't be loaded.
+@@ -1040,6 +1042,39 @@
+
+      -->
+
++  <!-- A request handler for MLT queries.
++    -->
++  <requestHandler name="/mlt" class="solr.MoreLikeThisHandler" />
++
++  <!-- A request handler for Facet, Highlight, and Spellcheck components
++    -->
++  <requestHandler name="/componentdemo" class="solr.SearchHandler">
++     <lst name="defaults">
++       <str name="echoParams">explicit</str>
++
++       <!-- Query settings -->
++       <str name="df">text</str>
++       <str name="defType">edismax</str>
++       <str name="qf">
++          text^0.5 features^1.0 name^1.2 sku^1.5 id^10.0 manu^1.1 cat^1.4
++          title^10.0 description^5.0 keywords^5.0 author^2.0 resourcename^1.0
++       </str>
++       <str name="mm">100%</str>
++       <str name="q.alt">*:*</str>
++       <str name="rows">10</str>
++       <str name="fl">*,score</str>
++
++       <str name="facet">on</str>
++       <str name="hl">on</str>
++       <str name="spellcheck">on</str>
++     </lst>
++
++     <!-- append spellchecking to our list of components -->
++     <arr name="last-components">
++       <str>spellcheck</str>
++     </arr>
++  </requestHandler>
++
+    <!-- Spell Check
+
+         The spell check component can return a list of alternative spelling

tests/Integration/Fixtures/schema9.patch tests/Integration/Fixtures/conf/schema9.patch

@@ -0,0 +1,44 @@
+diff --git a/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml b/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
+index 17d07d3c23c..d130a823f00 100644
+--- a/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
++++ b/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
+@@ -703,6 +703,39 @@
+     <int name="xsltCacheLifetimeSeconds">5</int>
+   </requestHandler>
+
++  <!-- A request handler for MLT queries.
++    -->
++  <requestHandler name="/mlt" class="solr.MoreLikeThisHandler" />
++
++  <!-- A request handler for Facet, Highlight, and Spellcheck components
++    -->
++  <requestHandler name="/componentdemo" class="solr.SearchHandler">
++     <lst name="defaults">
++       <str name="echoParams">explicit</str>
++
++       <!-- Query settings -->
++       <str name="df">text</str>
++       <str name="defType">edismax</str>
++       <str name="qf">
++          text^0.5 features^1.0 name^1.2 sku^1.5 id^10.0 manu^1.1 cat^1.4
++          title^10.0 description^5.0 keywords^5.0 author^2.0 resourcename^1.0
++       </str>
++       <str name="mm">100%</str>
++       <str name="q.alt">*:*</str>
++       <str name="rows">10</str>
++       <str name="fl">*,score</str>
++
++       <str name="facet">on</str>
++       <str name="hl">on</str>
++       <str name="spellcheck">on</str>
++     </lst>
++
++     <!-- append spellchecking to our list of components -->
++     <arr name="last-components">
++       <str>spellcheck</str>
++     </arr>
++  </requestHandler>
++
+    <!-- Spell Check
+
+         The spell check component can return a list of alternative spelling

tests/Integration/Fixtures/solrconf.patch tests/Integration/Fixtures/conf/solrconf7.patch

@@ -1,4 +1,3 @@
-version: '3.7'
 services:
   solr1:
     image: solr:7

tests/Integration/Fixtures/conf/solrconf8.patch

@@ -1,4 +1,3 @@
-version: '3'
 services:
   solr7:
     image: solr:7

tests/Integration/Fixtures/conf/solrconf9.patch

@@ -1,4 +1,3 @@
-version: '3.7'
 services:
   solr1:
     image: solr:8

tests/Integration/Fixtures/docker/solr7_cloud/docker-compose.yml

@@ -1,4 +1,3 @@
-version: '3'
 services:
   solr8:
     image: solr:8

tests/Integration/Fixtures/docker/solr7_server/docker-compose.yml

@@ -1,4 +1,3 @@
-version: '3.7'
 services:
   solr1:
     image: solr:9
@@ -7,6 +6,7 @@ services:
       - 8981:8983
     environment:
       - ZK_HOST=zoo1:2181,zoo2:2181,zoo3:2181
+      - SOLR_MODULES=extraction
     networks:
       - solr
     depends_on:
@@ -24,6 +24,7 @@ services:
       - 8982:8983
     environment:
       - ZK_HOST=zoo1:2181,zoo2:2181,zoo3:2181
+      - SOLR_MODULES=extraction
     networks:
       - solr
     depends_on:
@@ -36,6 +37,7 @@ services:
       - 8983:8983
     environment:
       - ZK_HOST=zoo1:2181,zoo2:2181,zoo3:2181
+      - SOLR_MODULES=extraction
     networks:
         solr:
             aliases:

tests/Integration/Fixtures/docker/solr8_cloud/docker-compose.yml

@@ -1,9 +1,10 @@
-version: '3'
 services:
   solr9:
     image: solr:9
     ports:
       - 8983:8983
+    environment:
+      - SOLR_MODULES=extraction
     networks:
         solr:
             aliases: