Skip to content

Commit c265245

Browse files
Unit test for Query::addParam()
1 parent ed974de commit c265245

File tree

2 files changed

+25
-0
lines changed

2 files changed

+25
-0
lines changed

src/Core/Query/QueryInterface.php

+11
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,17 @@ public function getHelper(): Helper;
9595
*/
9696
public function addParam(string $name, $value): self;
9797

98+
/**
99+
* Removes a param that was previously added by addParam.
100+
*
101+
* Note: This can not be used to remove known default parameters of the Solarium API.
102+
*
103+
* @param string $name
104+
*
105+
* @return self Provides fluent interface
106+
*/
107+
public function removeParam(string $name): self;
108+
98109
/**
99110
* Get extra params.
100111
*

tests/Core/Query/RequestBuilderTest.php

+14
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,20 @@ public function testBuildWithInteger()
6464
);
6565
}
6666

67+
public function testBuildWithArray()
68+
{
69+
$query = new SelectQuery();
70+
$query->addParam('p1', 'v1');
71+
$query->addParam('p2', ['a1', 'a2']);
72+
$query->setResponseWriter('xyz');
73+
$request = $this->builder->build($query);
74+
75+
$this->assertSame(
76+
'select?omitHeader=true&p1=v1&p2=a1&p2=a2&wt=xyz',
77+
urldecode($request->getUri())
78+
);
79+
}
80+
6781
public function testBuildWithHeader()
6882
{
6983
$query = new SelectQuery();

0 commit comments

Comments
 (0)