From 83bf0aa7f49838f2b484ade8ef477399baf92360 Mon Sep 17 00:00:00 2001 From: PaulPlay <80539587+therealPaulPlay@users.noreply.github.com> Date: Fri, 31 Jan 2025 23:33:20 +0100 Subject: [PATCH] Fix: Callbacks didn't clean up properly after .destroy() --- package.json | 2 +- src/index.js | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 8515e72..7593f1d 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "playpeerjs", - "version": "1.2.2", + "version": "1.2.3", "description": "WebRTC-based wrapper for creating robust peer-2-peer multiplayer systems with ease.", "type": "module", "main": "dist/playpeer.js", diff --git a/src/index.js b/src/index.js index 4176db8..ff4315a 100644 --- a/src/index.js +++ b/src/index.js @@ -589,6 +589,9 @@ export default class PlayPeer { this.#triggerEvent("destroy"); } + // Clear intervals + clearInterval(this.#heartbeatSendInterval); + // Resets this.#peer = undefined; this.#storage = {}; @@ -597,10 +600,7 @@ export default class PlayPeer { this.#hostConnectionsIdArray = []; this.#initialized = false; this.#maxSize = undefined; - - // Clear intervals - clearInterval(this.#heartbeatSendInterval); - this.#triggerEvent("status", "Resetted internal data."); + this.#callbacks.clear(); } catch (error) { console.error(ERROR_PREFIX + "Error during cleanup:", error); this.#triggerEvent("error", "Error during cleanup: " + error);