Skip to content

Commit 99093de

Browse files
authored
fix: Additional roles should only granted for Shared VPC when attaching to a service project (#542)
1 parent f297a3f commit 99093de

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

modules/shared_vpc_access/main.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ resource "google_project_iam_member" "gke_host_agent" {
8686
and https://cloud.google.com/kubernetes-engine/docs/how-to/cluster-shared-vpc#creating_additional_firewall_rules
8787
*****************************************/
8888
resource "google_project_iam_member" "gke_security_admin" {
89-
count = local.gke_shared_vpc_enabled && var.grant_services_security_admin_role ? 1 : 0
89+
count = local.gke_shared_vpc_enabled && var.enable_shared_vpc_service_project && var.grant_services_security_admin_role ? 1 : 0
9090
project = var.host_project_id
9191
role = "roles/compute.securityAdmin"
9292
member = format("serviceAccount:%s", local.apis["container.googleapis.com"])

0 commit comments

Comments
 (0)