Skip to content

Commit 0f12598

Browse files
authored
feat: added networkconnectivity in shared VPC host access (#876)
1 parent 7032b89 commit 0f12598

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

modules/shared_vpc_access/main.tf

+4
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ locals {
2929
"vpcaccess.googleapis.com" : format("service-%s@gcp-sa-vpcaccess.iam.gserviceaccount.com", local.service_project_number)
3030
"datastream.googleapis.com" : format("service-%s@gcp-sa-datastream.iam.gserviceaccount.com", local.service_project_number)
3131
"notebooks.googleapis.com" : format("service-%s@gcp-sa-notebooks.iam.gserviceaccount.com", local.service_project_number)
32+
"networkconnectivity.googleapis.com" : format("service-%s@gcp-sa-networkconnectivity.iam.gserviceaccount.com", local.service_project_number)
3233
}
3334
gke_shared_vpc_enabled = contains(var.active_apis, "container.googleapis.com")
3435
composer_shared_vpc_enabled = contains(var.active_apis, "composer.googleapis.com")
@@ -46,6 +47,8 @@ locals {
4647
if "dataflow.googleapis.com" compute.networkUser role granted to dataflow service account for Dataflow on shared VPC subnets
4748
if "composer.googleapis.com" compute.networkUser role granted to composer service account for Composer on shared VPC subnets
4849
if "notebooks.googleapis.com" compute.networkUser role granted to notebooks service account for Notebooks on shared VPC Project
50+
if "networkconnectivity.googleapis.com" compute.networkUser role granted to notebooks service account for Network Connectivity on shared VPC Project
51+
See: https://cloud.google.com/vpc/docs/configure-service-connection-policies#configure-host-project
4952
See: https://cloud.google.com/kubernetes-engine/docs/how-to/cluster-shared-vpc
5053
https://cloud.google.com/dataflow/docs/concepts/security-and-permissions#cloud_dataflow_service_account
5154
https://cloud.google.com/composer/docs/how-to/managing/configuring-shared-vpc
@@ -100,6 +103,7 @@ resource "google_compute_subnetwork_iam_member" "cloudservices_shared_vpc_subnet
100103
if "dataflow.googleapis.com" compute.networkUser role granted to dataflow service account for Dataflow on shared VPC Project if no subnets defined
101104
if "composer.googleapis.com" compute.networkUser role granted to composer service account for Composer on shared VPC Project if no subnets defined
102105
if "notebooks.googleapis.com" compute.networkUser role granted to notebooks service account for Notebooks on shared VPC Project if no subnets defined
106+
if "networkconnectivity.googleapis.com" compute.networkUser role granted to notebooks service account for Notebooks on shared VPC Project if no subnets defined
103107
*****************************************/
104108
resource "google_project_iam_member" "service_shared_vpc_user" {
105109
for_each = (length(var.shared_vpc_subnets) == 0) && var.enable_shared_vpc_service_project && var.grant_network_role ? toset(local.active_apis) : []

0 commit comments

Comments
 (0)