Lint fixes

Author: shanecglass

modules/data_warehouse/versions.tf

@@ -24,14 +24,6 @@ terraform {
       source  = "hashicorp/google-beta"
       version = ">= 4.52, < 6"
     }
-    random = {
-      source  = "hashicorp/random"
-      version = ">= 2"
-    }
-    archive = {
-      source  = "hashicorp/archive"
-      version = ">= 2"
-    }
     time = {
       source  = "hashicorp/time"
       version = ">= 0.9.1"

modules/data_warehouse/workflow_polling/main.tf

@@ -38,16 +38,13 @@ data "http" "call_workflows_state" {
 
 ## Parse out the workflow execution state from the API call response
 locals {
-  response_body = jsondecode(data.http.call_workflows_state.response_body)
+  response_body  = jsondecode(data.http.call_workflows_state.response_body)
   workflow_state = local.response_body.executions[0].state
-  depends_on = [
-    time_sleep.workflow_execution_wait,
-    data.http.call_workflows_state
-  ]
 }
 
 ## Output the workflow state to use as input for subsequent invocations
-output workflow_state {
+output "workflow_state" {
+  description = "State of the most recent workflow execution. Used to determine how to proceed with next polling run."
   value = local.workflow_state
 }
 

modules/data_warehouse/workflow_polling/variables.tf

@@ -4,7 +4,7 @@ variable "input_workflow_state" {
 }
 
 variable "workflow_id" {
-  type = string
+  type        = string
   description = "The identifer of a workflow created by Terraform. Format is projects/{project ID}/locations/{region}/workflows/{workflow name}"
 }
 

modules/data_warehouse/workflow_polling/versions.tf

@@ -0,0 +1,53 @@
+/**
+ * Copyright 2023 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+terraform {
+  required_providers {
+    google = {
+      source  = "hashicorp/google"
+      version = ">= 4.52, < 6"
+    }
+    google-beta = {
+      source  = "hashicorp/google-beta"
+      version = ">= 4.52, < 6"
+    }
+    random = {
+      source  = "hashicorp/random"
+      version = ">= 2"
+    }
+    archive = {
+      source  = "hashicorp/archive"
+      version = ">= 2"
+    }
+    time = {
+      source  = "hashicorp/time"
+      version = ">= 0.9.1"
+    }
+    http = {
+      source  = "hashicorp/http"
+      version = ">= 2"
+    }
+    local = {
+      source  = "hashicorp/local"
+      version = ">=2.4"
+    }
+  }
+  required_version = ">= 0.13"
+
+  provider_meta "google" {
+    module_name = "blueprints/terraform/terraform-google-bigquery:data_warehouse/v7.0.0"
+  }
+}