From 84ed77b62db080a5a89488daf312830f1383cc32 Mon Sep 17 00:00:00 2001 From: awwit Date: Mon, 27 Jan 2025 22:36:26 +0300 Subject: [PATCH 1/2] fix: improve settings error test: set the navigator language to en-US --- src/currency.test.js | 2 ++ src/settings.js | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/currency.test.js b/src/currency.test.js index 710ac14..0dbe981 100644 --- a/src/currency.test.js +++ b/src/currency.test.js @@ -50,6 +50,8 @@ const mockSettingState = { describe('currency', () => { beforeEach(() => { + jest.spyOn(navigator, 'language', 'get').mockReturnValue('en-US'); + api.init('test', 'pk_test'); api.settings.state = JSON.parse(JSON.stringify(mockSettingState)); api.currency.code = null; diff --git a/src/settings.js b/src/settings.js index 16f8fec..6093e2f 100644 --- a/src/settings.js +++ b/src/settings.js @@ -185,7 +185,11 @@ function methods(api, opt) { value: session, }); } catch (err) { - console.error(`Swell: unable to load settings (${err})`); + if (err instanceof Error) { + err.message = `Swell: unable to load settings (${err.message})`; + } + + console.error(err); } }, }; From d4917eff97a1cdb633dd921c1816cc5a523a0b1d Mon Sep 17 00:00:00 2001 From: awwit Date: Mon, 27 Jan 2025 22:55:12 +0300 Subject: [PATCH 2/2] test: spy on the navigator when it is available --- src/currency.test.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/currency.test.js b/src/currency.test.js index 0dbe981..4aea71c 100644 --- a/src/currency.test.js +++ b/src/currency.test.js @@ -50,7 +50,9 @@ const mockSettingState = { describe('currency', () => { beforeEach(() => { - jest.spyOn(navigator, 'language', 'get').mockReturnValue('en-US'); + if (typeof navigator !== 'undefined') { + jest.spyOn(navigator, 'language', 'get').mockReturnValue('en-US'); + } api.init('test', 'pk_test'); api.settings.state = JSON.parse(JSON.stringify(mockSettingState));