Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix #6

Open
zijiebite opened this issue Mar 17, 2021 · 3 comments
Open

bug fix #6

zijiebite opened this issue Mar 17, 2021 · 3 comments

Comments

@zijiebite
Copy link

  1. A tiny bug : in file tf2_model.py , from line 35 to 51 . It is obvious that the name and value of the args do not match.
    An easy fix : see the file "tf2_model.py" in the .zip attached
  2. A better (maybe) coding : in file tf2_module.py , function "build_generator" , line 152 to 162. The layer "PADDING_1" is not actually needed, if we only concern about the intelligibility of the code .
    I recommend to just alter the argument "padding" of Conv2D from 'valid' to 'same'. Actually you used " padding='same' " in the function "build_discriminator".

fix_zijiebite.zip

@sumuzhao
Copy link
Owner

Hi, thanks for your comments. Could you just pull a request that I can merge them directly?

@zijiebite
Copy link
Author

Sure!

@brkayaoglu
Copy link

If you trained all dataset, did you get the testable result @zijiebite ? If you get, can you share with me ? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants