Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the annotation icons in Text and Annotation Panels based on the User Config #566

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

orlinmalkja
Copy link
Contributor

@orlinmalkja orlinmalkja commented Feb 12, 2025

The user should provide a boolean value to showAnnotationIcons in the config.
When no value is given for this attribute no annotation icons are shown.

Closes #560

@orlinmalkja orlinmalkja self-assigned this Feb 12, 2025
@orlinmalkja orlinmalkja changed the title feat: show the annotation icons in Text and Annotation Panels based on the User Config Show the annotation icons in Text and Annotation Panels based on the User Config Feb 12, 2025
@@ -15,6 +15,7 @@ import { i18n } from '@/i18n';
collection: '',
manifest: '',
item: '',
showAnnotationIcons: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not what was requested. In #560 @mweidling is suggesting to omit the "icon" key on each annotation type config. TIDO then automatically recognizes that no icon should be rendered there. This enhances the modular nature of the config since you can decide per panel what to display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants