Skip to content

Commit 426a1dd

Browse files
authored
OTLPMetricPipeline fixed to no longer set global provider (open-telemetry#1787)
1 parent 4d2ac7f commit 426a1dd

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

opentelemetry-otlp/CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44

55
- Add "metrics", "logs" to default features. With this, default feature list is
66
"trace", "metrics" and "logs".
7+
- `OtlpMetricPipeline.build()` no longer invoke the
8+
`global::set_meter_provider`. User who setup the pipeline must do it
9+
themselves using `global::set_meter_provider(meter_provider.clone());`.
710

811
## v0.16.0
912

opentelemetry-otlp/examples/basic-otlp/src/main.rs

+1
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ async fn main() -> Result<(), Box<dyn Error + Send + Sync + 'static>> {
8585
result.err()
8686
);
8787
let meter_provider = result.unwrap();
88+
global::set_meter_provider(meter_provider.clone());
8889

8990
// Initialize logs and save the logger_provider.
9091
let logger_provider = init_logs().unwrap();

opentelemetry-otlp/src/metric.rs

+2-5
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
//! OTEL metric exporter
22
//!
3-
//! Defines a [MetricsExporter] to send metric data to backend via OTEL protocol.
3+
//! Defines a [MetricsExporter] to send metric data to backend via OTLP protocol.
44
//!
55
66
use crate::{NoExporterConfig, OtlpPipeline};
77
use async_trait::async_trait;
88
use core::fmt;
9-
use opentelemetry::{global, metrics::Result};
9+
use opentelemetry::metrics::Result;
1010

1111
#[cfg(feature = "grpc-tonic")]
1212
use crate::exporter::tonic::TonicExporterBuilder;
@@ -240,9 +240,6 @@ where
240240
}
241241

242242
let provider = provider.build();
243-
244-
global::set_meter_provider(provider.clone());
245-
246243
Ok(provider)
247244
}
248245
}

0 commit comments

Comments
 (0)