From a79753f37425c7c99fc4c33eb6aebd5622ca3a20 Mon Sep 17 00:00:00 2001 From: Steve Goodman <39279277+stoobie@users.noreply.github.com> Date: Sun, 7 Jan 2024 10:53:38 +0200 Subject: [PATCH 1/5] Minor edits to Setting up an account --- .../quick_start/pages/set_up_an_account.adoc | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc b/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc index 04f43cde3d..6b58085fdc 100644 --- a/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc +++ b/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc @@ -9,21 +9,17 @@ For information on creating a Starknet wallet as an end user, see link:https://w == Prerequisites -=== Ensure Starkli and Scarb are installed correctly - -Ensure that the following commands show the version information for Starkli and Scarb: - +* Starkli and Scarb are installed correctly. Ensure that the following commands show the version information for Starkli and Scarb: ++ [source, bash] ---- starkli --version scarb --version ---- - ++ If either command fails, see xref:environment_setup.adoc[Setting up your environment]. -=== Download, install and set up Argent X or Braavos wallet - -Install a Starknet wallet via Argent X or Braavos. For information on a specific wallet, including installation instructions, see that wallet’s site. +* A Starknet wallet is installed, either Argent X or Braavos. For information on a specific wallet, including installation instructions, see that wallet’s site. == Creating an account A smart wallet is composed of two parts: @@ -100,7 +96,7 @@ Fetch account config from an already deployed account contract ---- -The `fetch` command supports both Argent X and Braavos smart wallets. Make sure your wallet address is already deployed and input following command to create and save the account descriptor file: +The `fetch` command supports both Argent X and Braavos smart wallets. Make sure your wallet address is already deployed and input the following command to create and save the account descriptor file: [source,shell] ---- @@ -110,7 +106,7 @@ starkli account fetch --output ~/.starkli-wallets/deploye You can obtain access to a JSON-RPC endpoint in one of the following ways: - Host your own node with Pathfinder, Juno, or Papyrus. -- Use a third-party JSON-RPC API provider like Infura, Alchemy, Chainstack, or Nethermind. +- Use a third-party JSON-RPC API provider. For information on providers, see xref:tools:api-services.adoc[Full nodes and API services]. The following command shows the details of the account descriptor: @@ -146,9 +142,9 @@ If you are working with Braavos wallet, the type is defined as `braavos` and the ==== == Deploying an account -Once you have an account file, you can deploy the account contract with the starkli `account deploy` command. +Once you have an account file, you can deploy the account contract with the `starkli account deploy` command. -This command sends a `DEPLOY_ACCOUNT` transaction, which requires the account to be funded with some ETH for paying for the transaction fee. +This command sends a `DEPLOY_ACCOUNT` transaction, which requires the account to contain enough ETH to pay for the transaction fee. To deploy your account, run the following command: From a035c619519fc72fc3c0581c5bf50b42c514dfd1 Mon Sep 17 00:00:00 2001 From: Steve Goodman <39279277+stoobie@users.noreply.github.com> Date: Sun, 7 Jan 2024 10:54:57 +0200 Subject: [PATCH 2/5] Update components/Starknet/modules/quick_start/pages/set_up_an_account.adoc --- .../Starknet/modules/quick_start/pages/set_up_an_account.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc b/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc index 6b58085fdc..021b0eef94 100644 --- a/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc +++ b/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc @@ -96,7 +96,7 @@ Fetch account config from an already deployed account contract ---- -The `fetch` command supports both Argent X and Braavos smart wallets. Make sure your wallet address is already deployed and input the following command to create and save the account descriptor file: +The `fetch` command supports both Argent X and Braavos smart wallets. Make sure your wallet address is already deployed and enter the following command to create and save the account descriptor file: [source,shell] ---- From c8c54b2dcaa447257854afa309fa571f49b9bf8c Mon Sep 17 00:00:00 2001 From: Steve Goodman <39279277+stoobie@users.noreply.github.com> Date: Tue, 16 Jan 2024 11:33:49 +0200 Subject: [PATCH 3/5] Apply suggestions from code review Remove mention of Scarb from this topic. --- .../modules/quick_start/pages/set_up_an_account.adoc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc b/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc index 021b0eef94..88a216fc80 100644 --- a/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc +++ b/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc @@ -9,15 +9,14 @@ For information on creating a Starknet wallet as an end user, see link:https://w == Prerequisites -* Starkli and Scarb are installed correctly. Ensure that the following commands show the version information for Starkli and Scarb: +* Starkli is installed correctly. Ensure that the following command shows the version information for Starkli: + [source, bash] ---- starkli --version -scarb --version ---- + -If either command fails, see xref:environment_setup.adoc[Setting up your environment]. +If this command fails, see xref:environment_setup.adoc[Setting up your environment]. * A Starknet wallet is installed, either Argent X or Braavos. For information on a specific wallet, including installation instructions, see that wallet’s site. From d2739b6d50ce52c47715dc9c6f54c404054c3019 Mon Sep 17 00:00:00 2001 From: Steve Goodman <39279277+stoobie@users.noreply.github.com> Date: Tue, 16 Jan 2024 11:34:23 +0200 Subject: [PATCH 4/5] Update components/Starknet/modules/quick_start/pages/set_up_an_account.adoc --- .../Starknet/modules/quick_start/pages/set_up_an_account.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc b/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc index 88a216fc80..4407f3e646 100644 --- a/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc +++ b/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc @@ -9,7 +9,7 @@ For information on creating a Starknet wallet as an end user, see link:https://w == Prerequisites -* Starkli is installed correctly. Ensure that the following command shows the version information for Starkli: +Starkli is installed correctly. Ensure that the following command shows the version information for Starkli: + [source, bash] ---- From 206538d1cf024dc662aff646eb9f5d1d6bfe1200 Mon Sep 17 00:00:00 2001 From: Steve Goodman <39279277+stoobie@users.noreply.github.com> Date: Tue, 16 Jan 2024 11:34:59 +0200 Subject: [PATCH 5/5] Update components/Starknet/modules/quick_start/pages/set_up_an_account.adoc --- .../Starknet/modules/quick_start/pages/set_up_an_account.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc b/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc index 4407f3e646..88a216fc80 100644 --- a/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc +++ b/components/Starknet/modules/quick_start/pages/set_up_an_account.adoc @@ -9,7 +9,7 @@ For information on creating a Starknet wallet as an end user, see link:https://w == Prerequisites -Starkli is installed correctly. Ensure that the following command shows the version information for Starkli: +* Starkli is installed correctly. Ensure that the following command shows the version information for Starkli: + [source, bash] ----