Skip to content

Commit c798d0f

Browse files
authored
Fix Amazon dependencies versions (#3252)
1 parent cf1f363 commit c798d0f

File tree

4 files changed

+35
-58
lines changed

4 files changed

+35
-58
lines changed

setup.cfg

+2-2
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,8 @@ allenai =
132132

133133
amazon =
134134
boto3~=1.34.131
135-
awscli~=1.32.1
136-
botocore~=1.34.1
135+
awscli~=1.33.13
136+
botocore~=1.34.131
137137

138138
anthropic =
139139
anthropic~=0.17,<0.39 # TODO(#3212): Limit anthropic to >=0.39 after resolving #3212.

src/helm/benchmark/run_expander.py

+1-5
Original file line numberDiff line numberDiff line change
@@ -366,11 +366,7 @@ def expand(self, run_spec: RunSpec) -> List[RunSpec]:
366366
replace(
367367
run_spec,
368368
name=run_spec.name,
369-
adapter_spec=replace(
370-
run_spec.adapter_spec,
371-
global_prefix=NovaRunExpander.PROMPT
372-
+ "\n\n"
373-
),
369+
adapter_spec=replace(run_spec.adapter_spec, global_prefix=NovaRunExpander.PROMPT + "\n\n"),
374370
),
375371
]
376372

src/helm/clients/bedrock_client.py

+2-13
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
from helm.common.cache import CacheConfig
99
from helm.clients.client import CachingClient, truncate_and_tokenize_response_text
1010
from helm.common.request import Request, RequestResult, GeneratedOutput, wrap_request_time
11-
from helm.common.hierarchical_logger import htrack_block
1211
from helm.clients.bedrock_utils import get_bedrock_client, get_bedrock_client_v1
1312
from helm.tokenizers.tokenizer import Tokenizer
1413

@@ -99,7 +98,6 @@ def do_it() -> Dict[Any, Any]:
9998

10099

101100
class BedrockNovaClient(CachingClient):
102-
103101
"""
104102
Amazon Bedrock is a fully managed service that provides s selection of leading foundation models (FMs) from Amazon
105103
and other partner model providers.
@@ -125,23 +123,14 @@ def __init__(
125123

126124
def convert_request_to_raw_request(self, request: Request) -> Dict:
127125
model_id = request.model.replace("/", ".")
128-
messages = [
129-
{
130-
"role": "user",
131-
"content": [
132-
{
133-
"text": request.prompt
134-
}
135-
]
136-
}
137-
]
126+
messages = [{"role": "user", "content": [{"text": request.prompt}]}]
138127

139128
return {
140129
"modelId": model_id,
141130
"inferenceConfig": {
142131
"temperature": request.temperature,
143132
"maxTokens": request.max_tokens,
144-
"topP": request.top_p
133+
"topP": request.top_p,
145134
},
146135
"messages": messages,
147136
}

src/helm/clients/bedrock_utils.py

+30-38
Original file line numberDiff line numberDiff line change
@@ -74,45 +74,37 @@ def get_bedrock_client(
7474

7575

7676
def get_bedrock_client_v1(
77-
assumed_role: Optional[str] = None,
78-
service_name: str = "bedrock-runtime",
79-
region: str = "us-east-1",
80-
read_timeout: int = 5000,
81-
connect_timeout: int = 5000,
82-
retries: Dict = {"max_attempts": 10},
83-
):
84-
if region is None:
85-
target_region = os.environ.get("AWS_REGION", os.environ.get("AWS_DEFAULT_REGION"))
86-
else:
87-
target_region = region
88-
89-
boto_config = Config(
90-
read_timeout=read_timeout, connect_timeout=connect_timeout, retries=retries
91-
)
77+
assumed_role: Optional[str] = None,
78+
service_name: str = "bedrock-runtime",
79+
region: Optional[str] = "us-east-1",
80+
read_timeout: int = 5000,
81+
connect_timeout: int = 5000,
82+
retries: Dict = {"max_attempts": 10},
83+
):
84+
if region is None:
85+
target_region = os.environ.get("AWS_REGION", os.environ.get("AWS_DEFAULT_REGION"))
86+
else:
87+
target_region = region
9288

93-
if target_region is None:
94-
raise ValueError(
95-
"region environment variable is not set."
96-
)
97-
98-
if assumed_role:
99-
session = boto3.Session(region_name=target_region)
100-
# Assume role and get credentials
101-
sts = session.client("sts")
102-
creds = sts.assume_role(RoleArn=str(assumed_role),RoleSessionName="crfm-helm")["Credentials"]
103-
session = Session(
104-
aws_access_key_id=creds["AccessKeyId"],
105-
aws_secret_access_key=creds["SecretAccessKey"],
106-
)
107-
return session.client(
108-
service_name=service_name,
109-
region_name=target_region,
110-
config=boto_config,
111-
)
112-
113-
# default to instance role to get the aws credentials or aws configured credentials
114-
return boto3.client(
89+
boto_config = Config(read_timeout=read_timeout, connect_timeout=connect_timeout, retries=retries)
90+
91+
if target_region is None:
92+
raise ValueError("region environment variable is not set.")
93+
94+
if assumed_role:
95+
session = boto3.Session(region_name=target_region)
96+
# Assume role and get credentials
97+
sts = session.client("sts")
98+
creds = sts.assume_role(RoleArn=str(assumed_role), RoleSessionName="crfm-helm")["Credentials"]
99+
session = Session(
100+
aws_access_key_id=creds["AccessKeyId"],
101+
aws_secret_access_key=creds["SecretAccessKey"],
102+
)
103+
return session.client(
115104
service_name=service_name,
116105
region_name=target_region,
117-
config=boto_config
106+
config=boto_config,
118107
)
108+
109+
# default to instance role to get the aws credentials or aws configured credentials
110+
return boto3.client(service_name=service_name, region_name=target_region, config=boto_config)

0 commit comments

Comments
 (0)