Review comments

Author: sshlyapn

src/plugins/intel_gpu/src/graph/impls/ocl/border.cpp

@@ -150,7 +150,7 @@ struct border_impl : typed_primitive_impl_ocl<border> {
         return args;
     }
 
-    std::vector<BufferDescriptor> get_internal_buffer_descs_impl(const kernel_impl_params&) const override {
+    std::vector<BufferDescriptor> get_internal_buffer_descs(const kernel_impl_params&) const override {
         const auto& prim_params = static_cast<const kernel_selector::border_params&>(*_kernel_data.params);
         std::vector<BufferDescriptor> internal_buffers;
 

src/plugins/intel_gpu/src/graph/impls/ocl/multi_stage_primitive.hpp

@@ -157,7 +157,7 @@ struct multi_stage_primitive : public typed_primitive_impl<PType> {
         return _kernels;
     }
 
-    std::vector<BufferDescriptor> get_internal_buffer_descs_impl(const kernel_impl_params&) const override {
+    std::vector<BufferDescriptor> get_internal_buffer_descs(const kernel_impl_params&) const override {
         std::vector<BufferDescriptor> internal_buffers;
         for (auto& kd : _kernels_data) {
             if (kd.internalBuffers.empty())

src/plugins/intel_gpu/src/graph/impls/ocl/paged_attention.cpp

@@ -141,7 +141,7 @@ struct paged_attention_impl : multi_stage_primitive<paged_attention> {
         ob << make_data(&use_micro_sdpa, sizeof(bool));
     }
 
-    std::vector<BufferDescriptor> get_internal_buffer_descs_impl(const kernel_impl_params&) const override {
+    std::vector<BufferDescriptor> get_internal_buffer_descs(const kernel_impl_params&) const override {
         /*
         * Internal buffers allocation owners and users:
         * +--------------------------------------+--------------------+--------------------+

src/plugins/intel_gpu/src/graph/impls/ocl/primitive_base.hpp

@@ -184,7 +184,7 @@ struct typed_primitive_impl_ocl : public typed_primitive_impl<PType> {
         return _kernels;
     }
 
-    std::vector<BufferDescriptor> get_internal_buffer_descs_impl(const kernel_impl_params&) const override {
+    std::vector<BufferDescriptor> get_internal_buffer_descs(const kernel_impl_params&) const override {
         if (_kernel_data.internalBuffers.empty())
             return {};
 

src/plugins/intel_gpu/src/graph/impls/ocl/scaled_dot_product_attention.cpp

@@ -56,7 +56,7 @@ struct scaled_dot_product_attention_impl : multi_stage_primitive<scaled_dot_prod
     }
 
 protected:
-    std::vector<BufferDescriptor> get_internal_buffer_descs_impl(const kernel_impl_params&) const override {
+    std::vector<BufferDescriptor> get_internal_buffer_descs(const kernel_impl_params&) const override {
         // Look for the first sdpa_opt kernel entry. Currently, it can be used as default sdpa, indirect sdpa, or for both default
         // and indirect cases. All of sdpa_opt kernels use the same internal buffers, so we can find the first sdpa_opt and
         // use its` internal buffers configuration. The following scenarios are possible:

src/plugins/intel_gpu/src/graph/impls/onednn/primitive_onednn_base.h

@@ -572,7 +572,7 @@ struct typed_primitive_onednn_impl : public typed_primitive_impl<PType> {
         return event;
     }
 
-    std::vector<BufferDescriptor> get_internal_buffer_descs_impl(const kernel_impl_params&) const override {
+    std::vector<BufferDescriptor> get_internal_buffer_descs(const kernel_impl_params&) const override {
         if (_scratchpad_md.get_size() == 0)
             return {};
         return {BufferDescriptor({ov::PartialShape{static_cast<int64_t>(_scratchpad_md.get_size())},

src/plugins/intel_gpu/src/graph/impls/sycl/primitive_sycl_base.h

@@ -51,7 +51,7 @@ struct typed_primitive_sycl_impl : public typed_primitive_impl<PType> {
         }
     }
 
-    std::vector<BufferDescriptor> get_internal_buffer_descs_impl(const kernel_impl_params&) const override {
+    std::vector<BufferDescriptor> get_internal_buffer_descs(const kernel_impl_params&) const override {
         return {};
     }
 };

src/plugins/intel_gpu/src/graph/include/primitive_inst.h

@@ -42,7 +42,12 @@ template <class PType>
 class typed_primitive_inst;
 
 struct ImplementationManager;
-struct BufferDescriptor;
+
+struct BufferDescriptor {
+    explicit BufferDescriptor(const layout& l, bool lockable = false) : m_lockable(lockable), m_layout(l) {}
+    bool m_lockable = false;
+    layout m_layout;
+};
 
 /*
     Base class for all implementations.
@@ -148,12 +153,6 @@ struct ImplementationsFactory {
     bool has(impl_types impl_type) const;
 };
 
-struct BufferDescriptor {
-    explicit BufferDescriptor(const layout& l, bool lockable = false) : m_lockable(lockable), m_layout(l) {}
-    bool m_lockable = false;
-    layout m_layout;
-};
-
 /*
     Base class for all primitive instances.
     It's main responsibility is to allocate memory required to run single, specified in ctor,
@@ -522,10 +521,6 @@ struct typed_primitive_impl : public primitive_impl {
     }
 
     std::vector<BufferDescriptor> get_internal_buffer_descs(const kernel_impl_params& impl_params) const override {
-        return get_internal_buffer_descs_impl(impl_params);
-    }
-
-    virtual std::vector<BufferDescriptor> get_internal_buffer_descs_impl(const kernel_impl_params&) const {
         return {};
     }