Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not fix "empty-line-between-blocks" #87

Open
ksntcrq opened this issue Apr 1, 2019 · 2 comments
Open

Does not fix "empty-line-between-blocks" #87

ksntcrq opened this issue Apr 1, 2019 · 2 comments

Comments

@ksntcrq
Copy link

ksntcrq commented Apr 1, 2019

Problem Description

I saw some issues about the rule "empty-line-between-blocks" not being fixed that were resolved, but the problem still exists for me.

  • sass-lint-auto-fix v0.16.1
  • sass-lint v1.12.1

Some code

.sass-lint-auto-fix.yml

...
  empty-line-between-blocks: 1
...

.sass-lint

...
  empty-line-between-blocks:
    - 1
    - include: true
      allow-single-line-rulesets: false
...

The following codes will remain the same:

.question-and-answers {
    margin-bottom: 20px;
    &__question {
        margin-bottom: 15px;
    }
}
.settings-page {
    h2 {
        margin: 20px 0;
    }
    
    .form-horizontal {
        .label {
            display: inline-block;
        }
        .title {
            display: block;
        }
    }
}

The output of sass-lint-auto-fix will still give me:

@fix       Running resolver "empty-line-between-blocks" on "resources/assets/sass/studocu/pages/_settings.scss"
@write     Writing resolved tree to resources/assets/sass/studocu/pages/_settings.scss

So to sum up, everything seems working fine, except the files are not written (?) or the rule is not working (?).

@srowhani
Copy link
Owner

srowhani commented Apr 1, 2019

Thanks for the in-depth report! I'll be sure to look into this.

@besuhoff
Copy link

@srowhani any luck looking into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants