Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: fix beta clippy errors #3548

Merged
merged 8 commits into from
Feb 26, 2025
Merged

MRG: fix beta clippy errors #3548

merged 8 commits into from
Feb 26, 2025

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Feb 24, 2025

Fixes errors encountered in #3547. Note: includes #3547!

error: struct pattern is not needed for a unit variant
   --> src/core/src/errors.rs:167:48
    |
167 |             SourmashError::CannotUpsampleScaled { .. } => SourmashErrorCode::CannotUpsampleScaled,
    |                                                ^^^^^^^ help: remove the struct pattern
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern
    = note: `-D clippy::unneeded-struct-pattern` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::unneeded_struct_pattern)]`

error: struct pattern is not needed for a unit variant
   --> src/core/src/errors.rs:169:50
    |
169 |             SourmashError::NeedsAbundanceTracking { .. } => {
    |                                                  ^^^^^^^ help: remove the struct pattern
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern

error: struct pattern is not needed for a unit variant
   --> src/core/src/errors.rs:190:46
    |
190 |             SourmashError::HLLPrecisionBounds { .. } => SourmashErrorCode::HLLPrecisionBounds,
    |                                              ^^^^^^^ help: remove the struct pattern
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.99%. Comparing base (4045737) to head (ac517ce).
Report is 1 commits behind head on latest.

Files with missing lines Patch % Lines
src/core/src/errors.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #3548   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         136      136           
  Lines       22230    22230           
  Branches     2225     2225           
=======================================
  Hits        19561    19561           
  Misses       2356     2356           
  Partials      313      313           
Flag Coverage Δ
hypothesis-py 25.43% <ø> (ø)
python 92.32% <ø> (ø)
rust 81.95% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctb ctb enabled auto-merge (squash) February 26, 2025 14:38
@ctb ctb disabled auto-merge February 26, 2025 16:31
@ctb ctb merged commit a76da78 into latest Feb 26, 2025
42 of 43 checks passed
@ctb ctb deleted the fix_beta_lint branch February 26, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants