Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: support RocksDB databases in sourmash proper through FFI #3545

Open
wants to merge 17 commits into
base: latest
Choose a base branch
from
+3,508 −119

[pre-commit.ci] auto fixes from pre-commit.com hooks

4b3165d
Select commit
Loading
Failed to load commit list.
Open

WIP: support RocksDB databases in sourmash proper through FFI #3545

[pre-commit.ci] auto fixes from pre-commit.com hooks
4b3165d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 26, 2025 in 0s

48.77% (-39.22%) compared to 94a51c8

View this Pull Request on Codecov

48.77% (-39.22%) compared to 94a51c8

Details

Codecov Report

Attention: Patch coverage is 14.10256% with 134 lines in your changes missing coverage. Please review.

Project coverage is 48.77%. Comparing base (94a51c8) to head (4b3165d).
Report is 6 commits behind head on latest.

Files with missing lines Patch % Lines
src/sourmash/index/revindex.py 20.21% 75 Missing ⚠️
src/core/src/ffi/index/disk_revindex.rs 0.00% 57 Missing ⚠️
src/sourmash/save_load.py 60.00% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (94a51c8) and HEAD (4b3165d). Click for more details.

HEAD has 99 uploads less than BASE
Flag BASE (94a51c8) HEAD (4b3165d)
rust 14 1
hypothesis-py 7 1
python 80 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           latest    #3545       +/-   ##
===========================================
- Coverage   87.99%   48.77%   -39.22%     
===========================================
  Files         136      137        +1     
  Lines       22230    22385      +155     
  Branches     2225     2240       +15     
===========================================
- Hits        19561    10918     -8643     
- Misses       2356    11267     +8911     
+ Partials      313      200      -113

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov