Skip to content

Commit 879f7c6

Browse files
committed
Remove more compatibility code
1 parent 1e3e336 commit 879f7c6

File tree

4 files changed

+14
-30
lines changed

4 files changed

+14
-30
lines changed

runtests.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
from os.path import abspath, dirname, join
44
from shutil import rmtree
55
import sys
6-
import warnings
76

87
import django
98
from django.conf import settings
@@ -14,17 +13,21 @@
1413
rmtree(media_root, ignore_errors=True)
1514

1615
installed_apps = [
16+
'simple_history.tests',
17+
'simple_history.tests.custom_user',
18+
'simple_history.tests.external',
19+
'simple_history.tests.migration_test_app',
20+
21+
'simple_history',
22+
1723
'django.contrib.contenttypes',
1824
'django.contrib.auth',
1925
'django.contrib.sessions',
2026
'django.contrib.admin',
21-
'simple_history',
22-
'simple_history.tests',
23-
'simple_history.tests.external',
24-
'simple_history.tests.migration_test_app',
2527
]
2628

2729
DEFAULT_SETTINGS = dict(
30+
AUTH_USER_MODEL='custom_user.CustomUser',
2831
ROOT_URLCONF='simple_history.tests.urls',
2932
MEDIA_ROOT=media_root,
3033
STATIC_URL='/static/',
@@ -45,9 +48,6 @@
4548
}],
4649
)
4750

48-
if django.VERSION >= (1, 5):
49-
installed_apps.append('simple_history.tests.custom_user')
50-
DEFAULT_SETTINGS['AUTH_USER_MODEL'] = 'custom_user.CustomUser'
5151

5252
def main():
5353
if not settings.configured:

simple_history/admin.py

+2-8
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,7 @@ def get_urls(self):
3434
urls = super(SimpleHistoryAdmin, self).get_urls()
3535
admin_site = self.admin_site
3636
opts = self.model._meta
37-
try:
38-
info = opts.app_label, opts.model_name
39-
except AttributeError: # Django < 1.7
40-
info = opts.app_label, opts.module_name
37+
info = opts.app_label, opts.model_name
4138
history_urls = [
4239
url("^([^/]+)/history/([^/]+)/$",
4340
admin_site.admin_view(self.history_form_view),
@@ -146,10 +143,7 @@ def history_form_view(self, request, object_id, version_id):
146143
model_admin=self,
147144
)
148145

149-
try:
150-
model_name = original_opts.model_name
151-
except AttributeError: # Django < 1.7
152-
model_name = original_opts.module_name
146+
model_name = original_opts.model_name
153147
url_triplet = self.admin_site.name, original_opts.app_label, model_name
154148
context = {
155149
'title': _('Revert %s') % force_text(obj),

simple_history/models.py

+1-4
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,7 @@ def get_extra_fields(self, model, fields):
170170
def revert_url(self):
171171
"""URL for this change in the default admin site."""
172172
opts = model._meta
173-
try:
174-
app_label, model_name = opts.app_label, opts.model_name
175-
except AttributeError: # Django < 1.7
176-
app_label, model_name = opts.app_label, opts.module_name
173+
app_label, model_name = opts.app_label, opts.model_name
177174
return ('%s:%s_%s_simple_history' %
178175
(admin.site.name, app_label, model_name),
179176
[getattr(self, opts.pk.attname), self.history_id])

simple_history/tests/tests/test_admin.py

+3-10
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,7 @@
3131

3232

3333
def get_history_url(obj, history_index=None, site="admin"):
34-
try:
35-
app, model = obj._meta.app_label, obj._meta.module_name
36-
except AttributeError:
37-
app, model = obj._meta.app_label, obj._meta.model_name
34+
app, model = obj._meta.app_label, obj._meta.model_name
3835
if history_index is not None:
3936
history = obj.history.order_by('history_id')[history_index]
4037
return reverse(
@@ -67,12 +64,8 @@ def login(self, user=None):
6764
return form.submit()
6865

6966
def test_history_list(self):
70-
if VERSION >= (1, 5):
71-
try:
72-
module_name = self.user._meta.module_name
73-
except AttributeError:
74-
module_name = self.user._meta.model_name
75-
self.assertEqual(module_name, 'customuser')
67+
model_name = self.user._meta.model_name
68+
self.assertEqual(model_name, 'customuser')
7669
self.login()
7770
poll = Poll(question="why?", pub_date=today)
7871
poll._history_user = self.user

0 commit comments

Comments
 (0)