Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sonic-net/sonic-dhcpmon
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e00352233d4446ea10df2e9afc969d40409c3b86
Choose a base ref
...
head repository: sonic-net/sonic-dhcpmon
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f6dfbe923ae2085b05cb1dac7db7a5e4e505bf61
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Feb 18, 2025

  1. Fix counting bootp packets by mistake (#31) 

    Why I did it
In previous, if switch receives bootp packets with vendor specific options rather than DHCP body, dhcpmon would treat them as DHCP packets and count them. Since the packets body is not DHCP format, it's not expected and would cause incorrect counting data generated
image

How I did it
Per RFC 2131, add check for DHCP magic cookie to make sure dhcpmon would only count DHCP packets

How I verify it
Install new dhcpmon and send bootp packets manully and we can see bootp packets wouldn't be counted as DHCP packets
Install new dhcpmon and run dhcp_relay related tests in sonic-mgmt, all passed

Signed-off-by: Yaqiang Zhu <yaqiangzhu@microsoft.com>
    @yaqiangz
    yaqiangz authored Feb 18, 2025
    Copy the full SHA
    f6dfbe9 View commit details
Loading