Two issues related to sonicdev-microsoft.azurecr.io:443/docker-sonic-mgmt

[eddieruan-alibaba]

First issue:

Due to recent sonic-net/sonic-mgmt@1628450 's change

DOCKER_SONIC_MGMT is change from original "docker-sonic-mgmt" to "docker-sonic-mgmt:latest".

This changes breaks the check in pull_sonic_mgmt_docker_image() at

https://github.com/sonic-net/sonic-mgmt/blob/master/setup-container.sh#L143
https://github.com/sonic-net/sonic-mgmt/blob/master/setup-container.sh#L146

which leads always pulling docker image from docker registry. This is the first issue.

Second Issue

But this issue expose a more serious issue how to version control this image sonicdev-microsoft.azurecr.io:443/docker-sonic-mgmt

Currently, we always use "latest" version. The above two lines check "latest" as keyword, can't really verify if it is a really latest.

The one we cached is almost two years ago.
sonicdev-microsoft.azurecr.io:443/docker-sonic-mgmt latest 0c6bcf119fc8 22 months ago 2.82GB

which would use the following line to install needed python packages from /var/AzDevOps/env-python3/bin/pip to ${HOME}/env-python3 for none AzDevOps user.

https://github.com/sonic-net/sonic-mgmt/blob/master/setup-container.sh#L259

ubuntu@ubuntu:$ docker run -it sonicdev-microsoft.azurecr.io:443/docker-sonic-mgmt
AzDevOps@27225f73787d:$ cd /var/
AzDevOps@27225f73787d:/var$ cd AzDevOps/
AzDevOps@27225f73787d:~$ ls -l
total 8
drwxr-xr-x 2 AzDevOps gAzDevOps 4096 May 4 2023 bin
drwxr-xr-x 6 AzDevOps gAzDevOps 4096 May 4 2023 env-python3

But the latest image pulled from docker registry is the following

sonicdev-microsoft.azurecr.io:443/docker-sonic-mgmt latest 4a1aaf29ad26 2 weeks ago 3.92GB
ubuntu@ubuntu:$ docker run -it sonicdev-microsoft.azurecr.io:443/docker-sonic-mgmt
azureuser@81d51bef95ce:$ cd /var
azureuser@81d51bef95ce:/var$ ls
azureuser backups cache lib local lock log mail opt run spool tmp

The needed folder is no longer there.

That causes none AzDevOps user can't run sonic-mgmt test cases anymore since the needed packages are not in.

We might need to have a better version control on this image.

[arlakshm]

@yxieca and @wangxin, please help triage