yang: policer should not define cbs default value of 0

bradh352 · bradh352 · commit 20d3bd8f60dd · 2025-02-12T06:46:41.000-05:00
It looks like there is a behavior difference between libyang1 and
libyang3 where a default value of 0 was actually treated the same
as not set, so now the `POLICER_PIR_WITHOUT_CIR` test case is
failing with:
```
ERROR    YANG-TEST:test_yang_model.py:303 POLICER_PIR_WITHOUT_CIR: Mismatch ["pir can't be configured without cir."] and failed to parse data tree: cbs can't be configured without cir.: Data path: /sonic-policer:sonic-policer/POLICER/POLICER_LIST[name='e3policer']/cbs
```

Get rid of this bogus default.
diff --git a/src/sonic-yang-models/yang-templates/sonic-policer.yang.j2 b/src/sonic-yang-models/yang-templates/sonic-policer.yang.j2
@@ -66,7 +66,6 @@ module sonic-policer {
 						error-message "cbs must be greater than or equal to cir";
 					}
 					type uint64;
-					default 0;
 					description
 						"Committed burst size for the dual-rate token bucket
 						policer.  This value represents the depth of the token

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,6 @@ module sonic-policer {`
`66`	`66`	`error-message "cbs must be greater than or equal to cir";`
`67`	`67`	`}`
`68`	`68`	`type uint64;`
`69`		`- default 0;`
`70`	`69`	`description`
`71`	`70`	`"Committed burst size for the dual-rate token bucket`
`72`	`71`	`policer. This value represents the depth of the token`