update php dockerfile

solidbunch · Jun 23, 2024 · c69f17b · c69f17b
1 parent 9f20b37
commit c69f17b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/dockerfiles/php/Dockerfile b/dockerfiles/php/Dockerfile
@@ -1,7 +1,7 @@
 FROM php:8.1-fpm-alpine3.19
 
-ENV XDEBUG_VERSION 3.1.4
-ENV IMAGICK_VERSION 3.7.0
+ENV XDEBUG_VERSION=3.1.4
+ENV IMAGICK_VERSION=3.7.0
 
 ##################################
 #         Adding WP-CLI          #

diff --git a/sh/docker.sh b/sh/docker.sh
@@ -83,7 +83,7 @@ if [ "$MODE" == "push" ]; then
   # Step 1: Login to GitHub Container Registry (GHCR)
 
   #export CR_PAT=YOUR_TOKEN
-  #echo $CR_PAT | docker login ghcr.io -u USERNAME --password-stdin
+  echo "$GHCR_TOKEN" | docker login ghcr.io -u USERNAME --password-stdin
 
   # Step 2: Create a New Builder Instance
 

diff --git a/sh/env/.env.secret.template b/sh/env/.env.secret.template
@@ -72,3 +72,6 @@ APP_BA_PASSWORD=generate_this_pass
 # For GitHub Secrets
 #COMPOSER_AUTH={\"github-oauth\":{\"github.com\":\"ACCESS_TOKEN_GITHUB\"}}
 #COMPOSER_AUTH={"github-oauth":{"github.com":"ACCESS_TOKEN_GITHUB"}}
+
+# ghcr.io auth token for docker images push
+#GHCR_TOKEN=ACCESS_TOKEN