Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MusicSheetMaker song_creation as a list of self.methods? #123

Open
3 tasks
jmmelko opened this issue Apr 8, 2020 · 0 comments
Open
3 tasks

MusicSheetMaker song_creation as a list of self.methods? #123

jmmelko opened this issue Apr 8, 2020 · 0 comments
Labels
Bot Change required for the bot wontfix This will not be worked on

Comments

@jmmelko
Copy link
Collaborator

jmmelko commented Apr 8, 2020

I think it is possible to make the song_creation method a pure list of calls to self.methods, using only the recipient as the input parameter. To do, this 2 steps:

  • Create a retrieve_song_notes methods, which searches for the latest query about notes and get the notes out of it. Tricky part: handle files.
  • Make create_song a loop iterating over a dictionary of self.methods, calling them one by one, with recipient as the only parameter
  • Add an n integer or 'string' input parameter in create_song so we can skip to the call of method of the nth method or referenced by 'string'

Then, the code in the cog would become:

for i in range(len(maker.continue_song)):
    q = maker.continue_song(recipient=player, method=i)
    execute(q)
@jmmelko jmmelko added enhancement New feature or request Bot Change required for the bot labels Apr 8, 2020
@jmmelko jmmelko changed the title MusicSheetMaker song_creation as a list of self.methods MusicSheetMaker song_creation as a list of self.methods? Apr 9, 2020
@jmmelko jmmelko added wontfix This will not be worked on and removed enhancement New feature or request labels Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Change required for the bot wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant