Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: invoke the system version of cmd.exe #38

Open
dolmen opened this issue Jul 16, 2024 · 0 comments
Open

Windows: invoke the system version of cmd.exe #38

dolmen opened this issue Jul 16, 2024 · 0 comments

Comments

@dolmen
Copy link

dolmen commented Jul 16, 2024

RunWith should execute a secure version of cmd.exe, not any cmd.

open-golang/open/exec_windows.go

Line 30 in eef8423

cmd := exec.Command("cmd", "/C", "start", "", appName, cleaninput(input))

See https://msrc.microsoft.com/blog/2014/04/ms14-019-fixing-a-binary-hijacking-via-cmd-or-bat-file/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dolmen