API Do not raise user_error from Controller::curr() #11613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
emteknetnz
force-pushed
the
pulls/6.0/remove-ctrl-curr
branch
from
c243490 to
48e17a1
Compare
emteknetnz
changed the title
|
@emteknetnz I don't see removal of the deprecation warning - please check that #11614 got merged up and that this has been rebased |
emteknetnz
force-pushed
the
pulls/6.0/remove-ctrl-curr
branch
from
48e17a1 to
32598bb
Compare
|
Ah yup was missing, have done that now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11386
This PR also removes
Controller::has_curr()as it's no longer needed sinceController::curr()will now returnnullwhich can be tested against